1673611 - Make Http3Stream::WriteSegments be similar to nsHttpConnection::WriteSegments

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Dragana Damjanovic [:dragana]]

This should also add handling of stream errors that occurred while reading.
Until now this error were a connection error and they were handled by the Http3Session, but let's handling it by the stream as well.

This refactor should not change behavior.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Rewrite Http3Stream::WriteSegments to be similar to the nsHttpConnection's implementation

• This will make handling of responses contain only headers in the same way as the responses with
  a resonce body
• This will also make sure we pick up an error if neqo_http3conn_read_response_data return one.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Add a quic server

This will allow us to make response that violate the Http3 protocol and cause a protocol error.
Currently the server returns only one response, we may extend it if needed.

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: Improve Http3Stream state machine and add a test for a protocol error

• We have an assumption that SetResponseHeaders will be called before WriteSegments is called for the first time. I would like to make it more structural add add a new state BEFORE_HEADERS
• mDataReceived was never set, which is wrong.
• Almost any error that occurs during ReadResponseData is a connection error and neqo will handle it internally by closing the session. This will be read by necko as ConnectionState change event. Therefore ignore errors received from mHttp3Connection->ReadResponseData and let the ConnectionChange event close the stream.
• This also adds a test. Because the stream has received some data already the transaction will br closed with the NS_ERROR_NET_PARTIAL_TRANSFER error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ddde8f600dd
Rewrite Http3Stream::WriteSegments to be similar to the nsHttpConnection's implementation r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/c7e36d0608f6
Add a quic server r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/b4c5c16eb5d4
Improve Http3Stream state machine and add a test for a protocol error r=necko-reviewers,valentin

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ddde8f600dd
https://hg.mozilla.org/mozilla-central/rev/c7e36d0608f6
https://hg.mozilla.org/mozilla-central/rev/b4c5c16eb5d4