1673623 - Initialize the baseprofiler in xpcshell tests

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P1)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

Currently only the gecko profiler is initialized, which can lead to incorrect behavior, especially around the marker options for sending markers to the main thread.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1673623 - Initialize the baseprofiler in xpcshell tests; r?gerald

The baseprofiler is required to be in place first for features that are only
implemented in the baseprofiler, such as the MarkerThreadId::MainThread().
This patch adds the initialization, and upates the ProfilerIOInterposeObserver
to use baseprofiler-only features.

The issue before, was that the base profiler was not initialized, and the
mozilla::baseprofiler::profiler_main_thread_id() was incorrectly reporting that
the main thread index was 0.

No tests were changed in this patch, but it does have coverage with:

tools/profiler/tests/xpcshell/test_feature_fileioall.js

This test would fail with just the interposer changes.

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24f7a1d27f59edfba60835a38edd00fdf71edfa8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f48d38b9bc9
Initialize the baseprofiler in xpcshell tests; r=gerald

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2f48d38b9bc9

Comment 5

[Liam Wilson]

Hi, I think this may have introduced bug 1684389