Closed
Bug 1673738
Opened 5 years ago
Closed 4 years ago
Some .cpp files do not include all the header files they require
Categories
(Core :: DOM: Service Workers, task)
Core
DOM: Service Workers
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ytausky, Assigned: ytausky)
Details
Attachments
(1 file)
Due to the unified build, it's possible for a file to not include declarations for all the names it uses and not break the build. It does throw off clangd, though, so this should be fixed.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → ytausky
Status: NEW → ASSIGNED
Pushed by ytausky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3e402c60e55
Add missing includes to ServiceWorkerOp.cpp r=dom-workers-and-storage-reviewers,sg
|
|
Assignee | |
Updated•5 years ago
|
Keywords: leave-open
|
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:ytausky, maybe it's time to close this bug?
Flags: needinfo?(ytausky)
|
|
||
Comment 5•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:ytausky, maybe it's time to close this bug?
Flags: needinfo?(ytausky)
|
|
||
Updated•4 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
|
|
||
Updated•4 years ago
|
Keywords: leave-open
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(ytausky)
You need to log in
before you can comment on or make changes to this bug.
Description
•