1673758 - New tab Handoff/Private Browsing search bars should show a default icon for non-application provided engines

Status: VERIFIED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Per bug 1449338 comment 19, the search bar on the new tab page displays a default magnifying glass icon for non-application provided engines.

We should maintain that functionality with the search hand-off code.

This may get fixed by bug 1673727, but filing it for the record anyway.

Comment 1

[Mark Banner (:standard8)]

Updating summary for what this covers:

• When the browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar pref is enabled, we'll show the default magnifying glass for non-application provided engines. For application provided engines we'll show the engine icon.
• When in private mode, we'll do the same - currently we show a blank area for non-application provided engines.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1673758 - Search bar in the new tab page should show a default icon for non-app provided engines in all modes. r?daleharvey!

Depends on D96744

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=56cf3dc8a9c20b6a4867603dd17d47aac5389bd4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37f1ebdd131
Search bar in the new tab page should show a default icon for non-app provided engines in all modes. r=daleharvey

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b37f1ebdd131

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I've just tested this bug on windows 10 on FF Nightly 84.0a1 (2020-11-16) (64-bit) and the bug is no longer present. (sorry for the previous message, I mistook the bug)