1673821 - Error logged when closing DevTools with Storage inspector

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open DevTools
• select Storage panel
• close DevTools

The following error is logged:

Handler function threw an exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIObserverService.removeObserver]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://devtools/server/actors/storage.js :: StorageActors.defaults/destroy/< :: line 243"  data: no]
Stack: StorageActors.defaults/destroy/<@resource://devtools/server/actors/storage.js:243:24
destroy@resource://devtools/server/actors/storage.js:241:27
destroy@resource://devtools/server/actors/resources/utils/content-process-storage.js:203:24
unwatchAllTargetResources@resource://devtools/server/actors/resources/index.js:261:15
destroy@resource://devtools/server/actors/targets/browsing-context.js:623:15
onClosed/<@resource://devtools/server/devtools-server-connection.js:493:34
onClosed@resource://devtools/server/devtools-server-connection.js:493:19
close@resource://devtools/shared/transport/child-transport.js:63:18
close@resource://devtools/server/devtools-server-connection.js:94:23
onDisconnect<@resource://devtools/server/startup/frame.js:106:12
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
Line: 243, column: 0
console.error: ({})

The issue is that we are trying to destroy the storage actors twice. Once when closing the connection:

destroy@resource://devtools/server/actors/storage.js:240:19
destroy@resource://devtools/shared/protocol/Pool.js:189:17
destroy@resource://devtools/shared/protocol/Actor.js:76:11
destroy@resource://devtools/server/actors/targets/browsing-context.js:621:29
onClosed/<@resource://devtools/server/devtools-server-connection.js:493:34
onClosed@resource://devtools/server/devtools-server-connection.js:493:19
close@resource://devtools/shared/transport/child-transport.js:63:18
close@resource://devtools/server/devtools-server-connection.js:94:23
onDisconnect<@resource://devtools/server/startup/frame.js:106:12
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22

and once when unwatching all targets:

destroy@resource://devtools/server/actors/storage.js:239:19
destroy@resource://devtools/server/actors/resources/utils/content-process-storage.js:203:24
unwatchAllTargetResources@resource://devtools/server/actors/resources/index.js:261:15
destroy@resource://devtools/server/actors/targets/browsing-context.js:623:15
onClosed/<@resource://devtools/server/devtools-server-connection.js:493:34
onClosed@resource://devtools/server/devtools-server-connection.js:493:19
close@resource://devtools/shared/transport/child-transport.js:63:18
close@resource://devtools/server/devtools-server-connection.js:94:23
onDisconnect<@resource://devtools/server/startup/frame.js:106:12
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1673821 - [devtools] Fix error when closing storage panel

Introduce a guard in the actor's destructor, so it does not fail if called more than once.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission bugs for Fission MVP until we know whether they really need to block Fission or not.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d70a6bb9d63
[devtools] Fix error when closing storage panel r=jdescottes

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8d70a6bb9d63

Comment 5

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly on Windows 10 x64. I retested everything on macOS 10.13, Ubuntu 18.04 and Windows 10 x64 using Firefox 84.0 and Nightly 85.0a1. The issue is not reproducing anymore.