1673842 - Use ASurfaceControl with WebRender on Android

Status: NEW

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1673842 - Use ASurfaceControl for os compositor on Android

Comment 2

[Sotaro Ikeda [:sotaro]]

For now, ASurfaceControl with AndroidHardwareBuffer seems to work well with wr os compositor api. But it could cause performance problems on android.

• AndroidHardwareBuffer is a scarce resource. wr os compositor uses more hardware buffers than just default frame buffer.
• AndroidHardwareBuffer allocation is slow.
• When a lot of tiles are used by WebRender, it could make android SurfaceFlinger heavy weight.

Then it seems better if WebRender supports default frame buffer + Video/WebGL overlay like chromium. When Video/WebGL texture provides AndroidHardwareBuffer, the buffer could be directly posted to android SurfaceFlinger via ASurfaceControl.

:gw, is it possible to add "default frame buffer + Video/WebGL overlay" support to WebRender on Android?

Comment 3

[Glenn Watson [:gw]]

It could be possible, yes.

One option, for example, would be to have a single picture cache slice (possibly with larger tiles than default) and support a single compositor video / webgl surface.

Do you have any performance numbers for the cost per allocation / slowdown when using different number of tiles?

Comment 4

[Sotaro Ikeda [:sotaro]]

Great! I do not have an actual performance number. I am going to check it.

Comment 5

[Sotaro Ikeda [:sotaro]]

I tested with the current D95258. During scrolling, tiles were allocated and de-allocated regularly.

• AndroidHardwareBuffer creation : 0.4ms - 1.3ms
• EGLImage creation : 0.1ms - 0.3ms
• SurfaceControl creation : 0.5ms - 1.5ms

And ASurfaceControl transaction duration from commit to callback took 20ms - 40ms. It seems to mean android SurfaceFlinger became busy.

Since, when ASurfaceControl was used only for WebGL, ASurfaceControl transaction duration from commit to callback took around 10ms. And it does not have tile allocation/de-allocation.

D96523 was used to check "ASurfaceControl was used only for WebGL".

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1673842 - temporal patch. Use ASurfaceControl only for WebGL

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 9

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.