1673949 - Make some perf telemetry probes available in the Release channel (for Fission experiment)

Status: RESOLVED FIXED

(Core :: General, task, P3)

Description

[Chris Peterson [:cpeterson]]

@ Barret, FYI: I filed this bug for the engineering work for Jira ticket https://jira.mozilla.com/browse/FXP-1081.

The following telemetry probes are restricted to pre-release channels:

• KEYPRESS_PRESENT_LATENCY_MS
• SCALARS_GFX.OMTP.PAINT_WAIT_RATIO

The Fission team would like to monitor these probes for our Fission experiments on the Nightly, Beta, and Release channels. Thus we need an engineer to:

• determine that these probes are safe to collect by default in the Release channel
• then mark these probes as "releaseChannelCollection": "opt-out".

Tracking for Fission M7 milestone. While this fix doesn't block launching our Fission Beta experiment, we would like these probes to be available in Release around that same time so they can ride to the Release channel before we launch our Fission Release channel experiment.

Comment 1

[Chris Peterson [:cpeterson]]

We currently monitor the GC_SLICE_DURING_IDLE and MEMORY_UNIQUE_CONTENT_STARTUP probes for our Fission Nightly experiment, but these probes haven't been useful so far. We don't need to bother recording them in Release so I will remove them from this bug's list of probes in comment 0.

Comment 2

[Beth Rennie [:beth] (she/her)]

KEYPRESS_PRESENT_LATENCY should be available on release .

SCALARS_GFX.OMTP.PAINT_WAIT_RATIO is ok to move to release telemetry according to :rhunt.

:cpeterson, do we want to move this probe to release for the duration of the experiment or permanently?

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Barret Rennie [:barret] (they/them) from comment #2)

KEYPRESS_PRESENT_LATENCY should be available on release .

Awesome. I overlooked that.

SCALARS_GFX.OMTP.PAINT_WAIT_RATIO is ok to move to release telemetry according to :rhunt.

:cpeterson, do we want to move this probe to release for the duration of the experiment or permanently?

Would your code change specify a future Firefox version in which to expire this probe on the Release channel? Or just file a follow-up bug as a reminder to change this probe back to opt-in?

The Fission team will have no need for this probe after our Release channel experiment. That will probably be in 2021 Q2 or Q3 , but we don't know exactly when so I don't want to commit to an expiration date yet.

What do you recommend?

Comment 4

[Beth Rennie [:beth] (she/her)]

I think a follow up bug to move the probe off the release channel will be fine.

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: data-review.md

Comment 6

[Chris H-C :chutten]

Comment on attachment 9190953 [details]
data-review.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. Collection of this data on release will cease on or before 2021-10-01.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :barret is responsible for renewing or removing the collection before 2021-10-01.

---

Result: datareview+

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1673949 - Collect gfx.omtp.paint_wait_ratio on release channels r?cpeterson

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c9077b4da29
Collect gfx.omtp.paint_wait_ratio on release channels r=cpeterson

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5c9077b4da29