Closed
Bug 1674006
Opened 5 years ago
Closed 5 years ago
Add a null check for addon.sourceURI in InstallAddonFromURL
Categories
(Firefox :: Enterprise Policies, defect, P3)
Firefox
Enterprise Policies
Tracking
()
RESOLVED
FIXED
84 Branch
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details | Review |
We had a reported case of addonURI being null here:
And so addons don't finish installing.
This is a theoretical possibility, so I should have added a null check
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/7bb534f8271d
Add null check for addon source. r=emalysz
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9184402 [details]
Bug 1674006 - Add null check for addon source. r?emalysz!
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Simple null check for an edge addon install case that an enterprise was seeing.
- User impact if declined: Addons occasionally don't install via policy.
- Fix Landed on Version: 84
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just a null check.
- String or UUID changes made by this patch:
Attachment #9184402 -
Flags: approval-mozilla-esr78?
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9184402 [details]
Bug 1674006 - Add null check for addon source. r?emalysz!
Approved for 78.6esr.
Attachment #9184402 -
Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
|
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
status-firefox-esr78:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•