Closed Bug 1674006 Opened 2 years ago Closed 2 years ago

Add a null check for addon.sourceURI in InstallAddonFromURL

Categories

(Firefox :: Enterprise Policies, defect, P3)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- fixed
firefox84 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

Bug 1674006 - Add null check for addon source. r?emalysz!
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details | Review

We had a reported case of addonURI being null here:

https://searchfox.org/mozilla-central/rev/a147181ece866c1ecd176ac49f112785f960aac0/browser/components/enterprisepolicies/Policies.jsm#2265

And so addons don't finish installing.

This is a theoretical possibility, so I should have added a null check

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/7bb534f8271d
Add null check for addon source. r=emalysz

https://hg.mozilla.org/mozilla-central/rev/7bb534f8271d

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Comment on attachment 9184402 [details]
Bug 1674006 - Add null check for addon source. r?emalysz!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Simple null check for an edge addon install case that an enterprise was seeing.
  • User impact if declined: Addons occasionally don't install via policy.
  • Fix Landed on Version: 84
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a null check.
  • String or UUID changes made by this patch:
Attachment #9184402 - Flags: approval-mozilla-esr78?

Comment on attachment 9184402 [details]
Bug 1674006 - Add null check for addon source. r?emalysz!

Approved for 78.6esr.

Attachment #9184402 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.