1674029 - Add partial present support when using a native compositor

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Matt Woodrow (:mattwoodrow)]

SWGL should be able to be significantly faster if we can restrict compositing to the dirty area.

Ideally we'd be able to expose this before compositing (maybe Compositor::begin_compositing) so that we can only map a destination framebuffer for the area that we need.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Just to clarify a bit here, there's two separate steps that could have useful perf wins.

• Make EndFrame return the dirty rects, when native compositing it enabled. This would let us restrict the area that we copy from the SWGL backbuffer to the native Window.

• Expose the dirty rects earlier in compositing (BeginFrame/BeginCompositing), so that we can clip/scissor SWGL compositing itself and restrict SWGL compositing to the dirty area.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1674029 - Adjust compositor surface tile dirty rects by their transform if applicable. r?gw

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1674029 - Only commit the dirty rects in RenderCompositorSWGL. r?lsalzman

Depends on D96494

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bc569bc38c1
Adjust compositor surface tile dirty rects by their transform if applicable. r=gw
https://hg.mozilla.org/integration/autoland/rev/565ba6bf11b5
Only commit the dirty rects in RenderCompositorSWGL. r=lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9bc569bc38c1
https://hg.mozilla.org/mozilla-central/rev/565ba6bf11b5

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #27696 (as of Tue, 17 Nov 2020 05:59:20 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
2%	tsvgx		linux64-shippable-qr	e10s stylo webrender-sw	301.69 -> 295.00
2%	tsvgx		linux64-shippable-qr	e10s stylo webrender-sw	300.07 -> 294.59

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27696