167404 - Add a Cancel button and confirmation dialog when moving folders in Mail (especially for, but not limited to folders which are filter targets)

Status: NEW

(MailNews Core :: Filters, enhancement)

Description

[Mihail Daskalov]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2a) Gecko/20020906
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2a) Gecko/20020906

the alert that filters will be updated when moving folders in a mailbox is
useless unless it has a cancel button

Reproducible: Always

Steps to Reproduce:
1. Move a folder that has a filter attached to it (e.g. a filter causes moving
of messages to this folder)
2. Move this folder in another place
3. A dialog box appears, that has the message ('Filter will be updated'),
a checkbox to disallow further showing of this box, and OK button.



Actual Results:  
There is no 'Cancel button'.

Closing the dialog box with 'Esc key' or the 'X' button doesn't cancel the
moving of the folder

Expected Results:  
There should be 'Cancel' button.
Esc key, or 'Close window' command should prevent moving of the folder.

Sorry if this is a stupid bug filed on a work in progress, but I couldn't find
the bug under which this dialog is started to be written.

Comment 1

[laurel]

I don't think it's "useless" -- it does tell you that a filter change is upcoming.
I'm not sure we ever intended to build in a cancel here... revisit this handling
of moved/renamed folders again, cc jglick.

Comment 2

[Mihail Daskalov]

OK, I agree it's not completely useless - it's informational message.
After rethinking the situation my opinion is that it would be much more normal to 
either
1. have it displayed after that move has happened as an informational message,
or 
2. have the ability to cancel that action (if you display the message before the
actual move ahppens). 

Actually my personal opinion is it would be much better to display everytime an
confirmation dialog asking whether to really move the folder or not (and if
there are filter this to be included as part of the message).
It's not too hard to eventually drag n'drop a folder over another while
navigating among them.

Would be nice to have the ability to say 'Do not show this dialog any more' as
in the current version. Just this dialog to appear not only when there are filters.


I'll change summary from
'RFE: Cancel button for alert that filters will be updated when moving folders
in a mailbox' to
'RFE: add a Cancel button and confirmation dialog when moving folders in Mail'.

I know this is a little political thing - whether we should have confirmation
for an action - but that's why the checkboxes 'Do not show this dialog any more'
exist ;-)

Comment 3

[Eliot Lear]

It would be nice if there were a confirmation button when you move a folder at
all.  The way my interface appears (mailboxes on the left with a scrollbar) it
is very easy for me to accidentally move a mailbox instead of the scrollbar.  To
repeat this you merely need to have more mailboxes than the window provides
space for.

Comment 4

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 5

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 6

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 8

[Jerry Baker]

SOmeone should probably point out the Confirm Folder Move extension for Thunderbird. It should be automatically included in the default distribution:
https://addons.mozilla.org/en-US/thunderbird/addon/2152

Comment 9

[Pete Riley]

> Someone should probably point out the Confirm Folder Move extension for
> Thunderbird.

Unfortunately that extension doesn't work with TB3.0's new folder pane, even after adjusting the Max Version in the extension's xpi file.

While the new non-RDF folder tree might be a great advancement for Thunderbird, it has unfortunately broken several great extensions, some of which seem to be abandonware (e.g. AutoMsgSelect, ConfirmFolderMove, Empty Trash toolbar button, Select Inbox).

Comment 10

[:aceman]

Is this about confirmation of all folder moves, or only when there is a filter with "move to this folder"?

Comment 11

[Mihail Daskalov]

This was clarified (or redefined in comment #2) to be 'RFE: add a Cancel button and confirmation dialog when moving folders in Mail' in Mozilla Suite ...
So it is now about all folder moves.

Comment 12

[:aceman]

Wayne, this seems no longer to be about Filters. Probably another component would be better.

Pete, it seems the extension is compatible again.

It seems the code is there (in the extension). This needs info from the UI people if this is wanted in Thunderbird.

Comment 13

[Karsten Düsterloh]

MailNews Core is not Thunderbird!

Comment 15

[sphakka]

+1 for a *confirmation* dialogue! My point is that with sticky/malfunctioning touch pads it's so easy to accidentally move things around. I'd also raise the importance of this bug, as, currently, interrupting an ongoing move might result in lost mails -- though, "undo" should recover them. 

Gosh, this is one of the rare cases where a window$-like behaviour is advised ;-) Of course, confirmation on folder move should be configurable.

Comment 16

[el8]

I sometimes accidentally drag-and-drop folders, which causes them to move to unintended places. A confirmation dialog would indeed be nice.