1674129 - Firefox process is not always killed when "WebDriver:NewSession" is failing

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

When the creation of the new session fails the Marionette client isn't able to close Firefox via the delete session command, which is fine. But it also doesn't kill the currently running instance of Firefox, and leaves the process behind.

That also means that Marionette is trying again to connect to the former instance of Firefox when tests are run the next time.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Bug 1674129 - [marionette] Kill managed process if "New Session" command fails due to an unknown error.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Just making it clear that this is due to some unknown errors like global Javascript syntax errors.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/114720221065
[marionette] Kill managed process if "New Session" command fails due to an unknown error. r=marionette-reviewers,maja_zf

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Bug 1674129 - [marionette] Fix linting failure.

Depends on D96972

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f13566224d9
[marionette] Fix linting failure. r=marionette-reviewers,maja_zf

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/114720221065
https://hg.mozilla.org/mozilla-central/rev/2f13566224d9