1674175 - Add a memory reporter for memory allocated in NativeFontResourceMac::Create

Status: VERIFIED FIXED

(Core :: Graphics, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

It's very hard for us to encourage the system to free this memory so we should make sure we report it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1674175 - Add a memory reporter for memory allocated in NativeFontResourceMac::Create.

It's very hard for us to encourage the system to free this memory so we
should make sure we report it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac2bc30a33b
Add a memory reporter for memory allocated in NativeFontResourceMac::Create. r=mstange

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0ac2bc30a33b

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9184664 [details]
Bug 1674175 - Add a memory reporter for memory allocated in NativeFontResourceMac::Create.

Beta/Release Uplift Approval Request

• User impact if declined: We're a bit worried about bug 1625590. Without this we won't be able to track the memory allocated in NativeFontResourceMac::Create which will make it hard to judge the user impact of bug 1625590.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty low risk. There should be no user visible change in behaviour. We just have a new memory reporter. There's a small possibility that this could introduce an additional leak, but that doesn't seem likely.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9184664 [details]
Bug 1674175 - Add a memory reporter for memory allocated in NativeFontResourceMac::Create.

Low risk and needed for the investigation in bug 1625590, let's uplift into beta 8.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63f4bd13efb0

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

If manual testing is required here from QA (comment 4: "Needs manual test from QE?: Yes"), can you please provide us some steps to reproduce?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

"Needs manual test from QE?: Yes" was a mistake. Sorry.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also I had to use this new feature on Nightly over the last days. It works fine, and allowed me to find an easy test case to reproduce the behavior of Firefox we created this reporter for.