1674185 - Managed Bookmarks Placement sometimes ends up on right

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Mike Kaply [:mkaply]]

Some folks are doing some early testing of the ManagedBookmarks policy and seeing that the button ends up on the right sometimes (we have not officially released).

I believe this is result of the old static ManagedBookmarks code. For Firefox 83, we made things completely dynamic.

In order to make sure we are good for Firefox 83, I should be removing the old button from UI placement to make sure that we only use the dynamic button.

This is not an issue for ESR because it never had a release with the old code.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1674185 - Remove managed-bookmarks from uiCustomization.state now that it is dynamic. r?Gijs!

Comment 2

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]: This should go in 83 since that's the first release that uses the dynamic managed bookmarks code.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Patch for beta

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40634d195d8a
Remove managed-bookmarks from uiCustomization.state now that it is dynamic. r=Gijs

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/40634d195d8a

Comment 6

[Pascal Chevrel:pascalc]

Mike, are you going to request an uplift for this today before our last beta? Thanks

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9185310 [details] [diff] [review]
Patch for beta

Beta/Release Uplift Approval Request

• User impact if declined: Managed bookmarks present in pref when it's not really there, so sometimes button ends up in the wrong place when managed bookmarks is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Install Firefox 82. Go to about:config and check browser.uiCustomization.state and see that the value of Personal toolbar looks like this:
  "PersonalToolbar":["personal-bookmarks","managed-bookmarks"]}
  Update to a beta with this fix, and managed-bookmarks will be removed.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy related only,
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9185310 [details] [diff] [review]
Patch for beta

Approved for 83 beta 9, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5cd64a1b1848

Comment 10

[Emil Ghitta, QA [:emilghitta]]

Hi Mike,

I have performed an update from Firefox 82.0b9 to 83.0 and I can still find the value of PersonalToolbar":["managed-bookmarks","personal-bookmarks"] inside the about:config page for the browser.uiCustomization.state pref using Windows 10 64bit.

Am I missing something? should a certain policy be active while performing the steps from comment 7?

Comment 11

[Mike Kaply [:mkaply]]

Going from 82 to 83 is the way to see the fix, but even that isn't working for some reason.

I'll investigate and see if I need a better workaround for 84, but for now, you can drop it off the list.

This was an edge case I was hoping to fix, but clearly failed.