1674194 - Tables with aria roles on cells or rows should be layout tables

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

Gmail has a catagory tab list that looks roughly like this:

<table>
  <tr role="tablist">
    <td role="heading" aria-level="3">
      <div tabindex="0" role="tab" aria-selected="true">Primary</div>
    </td>

    <td role="heading" aria-level="3">
      <div tabindex="0" role="tab" aria-selected="false">Promotions</div>
    </td>

    <td role="heading" aria-level="3">
      <div tabindex="0" role="tab" aria-selected="false">Forums</div>
    </td>
  <tr>
    <td colspan="5">
      <div></div>
    </td>
  </tr>
</table>

While this table is clearly used for layout purposes, our IsProbablyLayoutTable implementation does not detect it to be so because of the plurality of cells and their distinct styling. I think we need to add a heuristic there that returns true if cell or row elements are being assigned an aria role that is not table related.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1674194 - If cell or row has aria role, make it a layout table. r?Jamie!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1d158fe6028
If cell or row has aria role, make it a layout table. r=Jamie

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c1d158fe6028