1674221 - Prefix Skeleton UI keys with executable path

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Alex Thayer [:alexical] (she/her)]

We should prefix our skeleton UI keys with the executable path, similar to the launcher registry keys, so that different Firefox installs don't clobber each other's skeleton UI settings.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin

This is not particularly related to the bug, but it's small enough that it
hardly warrants its own bug.

Depends on D95541

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5092fde1ebe1
Prefix Skeleton UI reg names with exe path r=agashlin
https://hg.mozilla.org/integration/autoland/rev/3d9b951db0f4
Make skeleton UI pref visible to windows users r=agashlin

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for SM bustages on PreXULSkeletonUI.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/c9bb0d25e007f4a69c69f7095af239ad383265c6
Log link: https://treeherder.mozilla.org/logviewer?job_id=320867188&repo=autoland&lineNumber=4196

Comment 5

[Alex Thayer [:alexical] (she/her)]

Right. SpiderMonkey, which I definitely meant to test. 🤦‍♂️

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c98182657e6c
Prefix Skeleton UI reg names with exe path r=agashlin
https://hg.mozilla.org/integration/autoland/rev/e0b0efa141af
Make skeleton UI pref visible to windows users r=agashlin

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c98182657e6c
https://hg.mozilla.org/mozilla-central/rev/e0b0efa141af