Closed Bug 1674281 Opened 4 years ago Closed 8 months ago

./mach clang-format does different things depending on whether the repo is hg or git

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P2)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jrmuizel, Unassigned)

References

Details

On an hg repo ./mach clang-format will reformat the most recent commit. On a git repo ./mach clang-format only reformats the pending changes. One needs to use ./mach clang-format -c HEAD to get the same behaviour as with a mercurial repo.

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bpostelnicu)
Severity: -- → S2
Flags: needinfo?(bpostelnicu)
Priority: -- → P2
Product: Firefox Build System → Developer Infrastructure

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)

On an hg repo ./mach clang-format will reformat the most recent commit.

Sometimes it does. Sometimes it does not.

See Also: → 1545276

With the git move, we won't have inconsistency anymore.

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.