1674372 - Private session do not finish loading if a new private session has the same url

Status: RESOLVED INVALID

(GeckoView :: General, defect, P1)

Description

[Arturo Mejia [:amejia]]

Attachment: not_working_private_session.txt

GV 84.0.20201029095639
The issue appears only with urls that redirect

STR:

1. Create a private session with this url
2. It should finish loading and trigger onExternalResponse
3. Create a new private session with the same url
4. The onExternalResponse should be triggered but it wasn't as the url never finish loading, the loading progress got stocked at 15.

I attached files which include the working case steps 1 to 2 (working_private_session.txt)
and the not working case steps 3 to 4(not_working_private_session.txt).

On not_working_private_session.txt you can see that the session loads until 15 but it never finishes.

2020-10-29 15:17:24.231 20395-20489/org.mozilla.fenix.debug D/GeckoViewProgress: ProgressTracker onStateChange: isTopLevel=true, flags=0xf0001, status=NS_OK
2020-10-29 15:17:24.231 20395-20489/org.mozilla.fenix.debug D/GeckoViewProgress: ProgressTracker onStateChange: uri=https://www.google.com/url?q=https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf&sa=U&ved=2ahUKEwjxo92BsdrsAhXpB50JHQWNAy8QFjAAegQIChAB&usg=AOvVaw2igpBdWxSTgRxf7wUkfa5R
2020-10-29 15:17:24.232 20395-20489/org.mozilla.fenix.debug D/GeckoViewProgress: ProgressTracker start https://www.google.com/url?q=https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf&sa=U&ved=2ahUKEwjxo92BsdrsAhXpB50JHQWNAy8QFjAAegQIChAB&usg=AOvVaw2igpBdWxSTgRxf7wUkfa5R
2020-10-29 15:17:24.232 20395-20489/org.mozilla.fenix.debug D/GeckoViewProgress: ProgressTracker updateProgress
2020-10-29 15:17:24.232 20395-20489/org.mozilla.fenix.debug D/GeckoViewProgress: ProgressTracker updateProgress data={"prev":0,"uri":"https://www.google.com/url?q=https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf&sa=U&ved=2ahUKEwjxo92BsdrsAhXpB50JHQWNAy8QFjAAegQIChAB&usg=AOvVaw2igpBdWxSTgRxf7wUkfa5R","locationChange":false,"pageStart":true,"pageStop":false,"firstPaint":false,"pageShow":false,"parsed":false} progress=15

Comment 1

[Arturo Mejia [:amejia]]

Attachment: working_private_session.txt

Comment 3

[Emily Toop (:fluffyemily)]

Non private session STR can be found in bug 1687540 and should be tested/included with this fix

Comment 4

[[:owlish] 🦉 PST]

Arturo, couple of questions:

1. Does this still reproduce for you? Does this reproduce in GVE for you?
2. The link is https://www.google.com/url?q=https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf&sa=U&ved=2ahUKEwjxo92BsdrsAhXpB50JHQWNAy8QFjAAegQIChAB&usg=AOvVaw2igpBdWxSTgRxf7wUkfa5R <-- is it correct? with google search etc.? Or did you mean https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf?

Comment 5

[[:owlish] 🦉 PST]

I have tried reproducing this bug in GVE, and, according to the ProgressTracker, both the urls (the redirecting one and normal one) load 100%
The onExternalResponse is called both times, in the first tab and the second tab, both in private browsing and normal browsing. (both the redirecting link and normal).

Are you sure this is a GV problem?

Comment 6

[Arturo Mejia [:amejia]]

1. No as GVE work a bit different when downloading, it doesn't have a prompt.
2. Both should be valid, I sent the long one initially because I thought the issue had to do with the redirect.

Here you can see clearly the STR in Firefox nightly https://drive.google.com/file/d/1Pyt8H-wV2LG14sLP3BCj_Pm-qf4K5p9B/view?usp=sharing

I think I realized what is the issue, when the user request the download and the download doesn't finish (The prompt gets canceled), GV can't provide a new onExternalResponse event, even if it's a new tab as it's not aware that the previous download was canceled, the issue is on AC as we are not closing the steam, when I close the stream on the ac side the issue goes away.

I will close this issue, and put a patch on the AC side, thanks for all the help and sorry for the troubles.