Add ability to hide the top site section's title
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | unaffected |
| firefox83 | --- | fixed |
| firefox84 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
6.70 KB,
patch
|
pascalc
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Late design adjustment from Connor and Verdi.
| Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Backed out changeset 6787c96a69c8 (bug 1674433) for newtab failure. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=320586059&repo=autoland&lineNumber=91
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=6787c96a69c859ed4faf3ebb9d15a713fd9458c8
Backout:
https://hg.mozilla.org/integration/autoland/rev/01fc59105b9a23a52b6cf2725082ac2a258ebc80
| Assignee | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 6•5 years ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]: bug 1653929
[User impact if declined]: late design adjustment requested by mconnor and verdi
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: no
[Why is the change risky/not risky?]: this is behind a new hidden pref: browser.newtabpage.activity-stream.hideTopSitesTitle
[String changes made/needed]: -
Comment 7•5 years ago
|
||
Comment on attachment 9185724 [details] [diff] [review]
patch for uplift
Uplift approved for our last beta, thanks.
Comment 8•5 years ago
|
||
| bugherder uplift | ||
Description
•