167446 - After deleting a toolbar bookmark, attempting to get info on another toolbar bookmark results in crash

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Chris Petersen]

Build: 2002-09-07-05
Platform: OS X 10.2
Expected Results: Get Info panel should appear 
What I got: Application crashes

Steps to reproduce:

1) Control -click on any toolbar bookmark and select Get Info menu item.
2) Get Info panel appears. Close this panel.
3)  Control -click on the same toolbar bookmark again and select Delete menu item.
4) Now, Control -click on any toolbar bookmark and select Get Info menu item
once more .
5) Application should crash.

Comment 1

[Chris Petersen]

Attachment: stack trace

Comment 2

[David Haas (gone, not reading mail)]

Attachment: patch

this: 
+  if (![[self window] isVisible])
+    mBookmarkItem = nil;

is all that's needed to fix this bug.  the next obvious bug
that comes out of this (and may be filed already - haven't checked)
would be the crash from when you delete the bookmark while the info
window is still open, then click on the info window.  the rest of the
patch fixes that bug.  

at this point, there may be some extra paranoia in some of the checks
in this info panel, but so what.

Comment 3

[Simon Fraser [no longer active]]

Patch checked in -- thanks! I also hooked up the context menu again.

Comment 4

[Chris Petersen]

Fixed in the 2002-10-02-04 NB.