1674564 - Perma Assertion failure: !mTimer, at /builds/worker/checkouts/gecko/dom/serviceworkers/ServiceWorkerShutdownBlocker.cpp:258 when Gecko 84 merges to Beta on 2020-11-16

Status: VERIFIED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Cristina Coroiu [:ccoroiu]]

Central as beta simulation:
https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=8f538bc9c23b1bce55abfa3fd21d4239eee80e61&selectedTaskRun=Fm_sbOPNT1yg5czRMDTmaw.0

Failure logs:
Mochitest: https://treeherder.mozilla.org/logviewer?job_id=320346212&repo=try&lineNumber=8017

Mn: https://treeherder.mozilla.org/logviewer?job_id=320346272&repo=try&lineNumber=29435

Xpcshell: https://treeherder.mozilla.org/logviewer?job_id=320346182&repo=try&lineNumber=3341

bc: https://treeherder.mozilla.org/logviewer?job_id=320346230&repo=try&lineNumber=14852

Comment 1

[Jens Stutte [:jstutte]]

I do not think that this has been regressed by bug 1588152 alone, since it landed quite a while ago.

But the assert seems to check, if we have a reentrant call to ServiceWorkerShutdownBlocker::MaybeInitUnblockShutdownTimer(). In fact we are calling it in two different sites, which makes me think that some other change causes now a double call.

Simple fix might be to remove the assert and just return if we already initiated the timer on this shutdown blocker. I cannot really see that this would be dangerous, asuth?

Comment 2

[Jens Stutte [:jstutte]]

Oh, and to avoid different code between nightly and release: Can't we just set a very long timeout in nightly on that timer rather than conditionally compile all that code?

Comment 3

[Jens Stutte [:jstutte]]

Attachment: Bug 1674564 - Make ServiceWorkerShutdownBlocker::MaybeInitUnblockShutdownTimer robust against re-entrance r=#dom-workers-and-storage

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c387ce5635b3
Make ServiceWorkerShutdownBlocker::MaybeInitUnblockShutdownTimer robust against re-entrance r=dom-workers-and-storage-reviewers,asuth

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c387ce5635b3

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation.