1674613 - nsDirectoryService.cpp: do not use 'else' after 'return'

Status: RESOLVED INVALID

(Core :: XPCOM, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/xpcom/io/nsDirectoryService.cpp#234-242

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Simon Giesecke [:sg] [he/him]]

This is the same situation as that mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1674633#c4, so this is also a false-positive.