1674719 - Warp: Transpile remaining sparse elements CacheIR instructions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 1: Add MacroAssembler::branchIfObjectNotExtensible. r=jandem!

Add MacroAssembler::branchIfObjectNotExtensible() in preparation for the next
part. Also allows to remove the CacheIRCompiler friend declaration in
JSObject.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 2: Transpile GuardIsExtensible. r=jandem!

Depends on D95489

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 3: Transpile GuardIsNonNegative. r=jandem!

Depends on D95490

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 4: Transpile GuardIndexGreaterThanDenseInitLength. r=jandem!

Depends on D95491

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 5: Transpile GuardIndexIsValidUpdateOrAdd. r=jandem!

Increases SNAPSHOT_BAILOUTKIND_BITS because we're now using more than 64
bailout kinds.

Depends on D95492

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 6: Transpile CallAddOrUpdateSparseElementHelper. r=jandem!

Depends on D95493

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 7: Transpile CallGetSparseElementResult. r=jandem!

Depends on D95494

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 8: Transpile CallNativeGetElementResult. r=jandem!

Depends on D95495

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 9: Transpile GuardIsNativeObject. r=jandem!

Depends on D95496

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 10: Transpile LoadDenseElementHoleExistsResult. r=jandem!

Reuses the existing MInArray instruction by adding a flag whether or not
negative indices can be handled. After removing IonBuilder we can remove
that flag again.

Depends on D95497

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1674719 - Part 11: Transpile CallObjectHasSparseElementResult. r=jandem!

Depends on D95498

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae381c4c2d6
Part 1: Add MacroAssembler::branchIfObjectNotExtensible. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0e44eee572d3
Part 2: Transpile GuardIsExtensible. r=jandem
https://hg.mozilla.org/integration/autoland/rev/401684e17cc6
Part 3: Transpile GuardIsNonNegative. r=jandem
https://hg.mozilla.org/integration/autoland/rev/30c2b763b2fc
Part 4: Transpile GuardIndexGreaterThanDenseInitLength. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c8404b49ea65
Part 5: Transpile GuardIndexIsValidUpdateOrAdd. r=jandem
https://hg.mozilla.org/integration/autoland/rev/581212aec52e
Part 6: Transpile CallAddOrUpdateSparseElementHelper. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7979b0c27840
Part 7: Transpile CallGetSparseElementResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ca4ab7f266fe
Part 8: Transpile CallNativeGetElementResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a18c54374673
Part 9: Transpile GuardIsNativeObject. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f48ed899f748
Part 10: Transpile LoadDenseElementHoleExistsResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7e6089e75b47
Part 11: Transpile CallObjectHasSparseElementResult. r=jandem

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ae381c4c2d6
https://hg.mozilla.org/mozilla-central/rev/0e44eee572d3
https://hg.mozilla.org/mozilla-central/rev/401684e17cc6
https://hg.mozilla.org/mozilla-central/rev/30c2b763b2fc
https://hg.mozilla.org/mozilla-central/rev/c8404b49ea65
https://hg.mozilla.org/mozilla-central/rev/581212aec52e
https://hg.mozilla.org/mozilla-central/rev/7979b0c27840
https://hg.mozilla.org/mozilla-central/rev/ca4ab7f266fe
https://hg.mozilla.org/mozilla-central/rev/a18c54374673
https://hg.mozilla.org/mozilla-central/rev/f48ed899f748
https://hg.mozilla.org/mozilla-central/rev/7e6089e75b47