167476 - unix_timestamp conversion error using MySQL

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P1)

Description

[Finn Normann Pedersen]

Line 275 in reports.cgi generated for linux/mysql. Bugzilla version 1.14.1.

reads:
unix_timestamp(date_format(bugs.creation_ts, '%Y-%m-%d %h:%m:%s'))

There is a simple error converting the minutes using %m which reference months.
Should have been %i.

This part of the SQL-sentence does not take into account european formated dates
running from 0-23 - in mysql not %h, but %H; nor does it take into account use
of 0-11 clocks using AM/PM formated strings by adding %p.

The correct string for 0-23 hour clock: '%Y-%m-%d %H:%i:%s'

The correct string for 0-11 hour clock: '%Y-%m-%d %h:%i:%s %p'

Comment 1

[Gervase Markham [:gerv]]

Fixed.

Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.59; previous revision: 1.58
done

Gerv