Closed Bug 1674796 Opened 4 years ago Closed 3 years ago

Phabricator emails: Use threading headers

Categories

(Conduit :: Phabricator, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mhentges, Assigned: mhentges)

References

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

See this report on Matrix.
For most email clients (except for GMail), there's a "thread" header that is respected for grouping emails. This makes threads resilient to subject changes.
We should use this header.

Keywords: conduit-triaged
Priority: -- → P3

Yes, the standard header is "References"

The "legacy" notifications had the References header and threading worked as expected. The new "Mozilla Notifications" do not have this header, so threading does not work in Thunderbird.

For those whose clients don't thread by email subject, you can revert back to the builtin Phabricator Emails until this is resolved.

See also bug 1535688 (where it was triaged as conduit-upstream, but it sounds like there may not be an upstream anymore?). Also note that there is a setting to prevent Phabricator from changing subject lines, which has been helpful for me in getting decent threading with both the new and old email formats.

where it was triaged as conduit-upstream, but it sounds like there may not be an upstream anymore?

Yeah, there's two different email implementations: the builtin/upstream Phabricator one, and the Mozilla one that because the new default yesterday (which this bug is in reference to, I believe).

Also note that there is a setting to prevent Phabricator from changing subject lines

The new Phabricator emails don't change subject lines by default (unless the revision title changes). It doesn't currently integrate with that setting.
However, there has been an issue floating around about emails with the same subject not being threaded in GMail, which is worth investigating, but is a bit orthogonal to this ticket.

There's more action in this ticket than I anticipated, I'll take a look.

Assignee: nobody → mhentges
Status: NEW → ASSIGNED
See Also: → 1697883

This has landed, but I'll leave another comment when it's deployed.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

This has been deployed.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: