Closed Bug 1674863 Opened 3 years ago Closed 3 years ago

Add GetIntrinsicSize() override for nsVideoFrame

Categories

(Core :: Layout, defect)

defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(3 files)

Bug 1669885 Part 2 added the support for all replaced elements which implements GetIntrinsicSize() in ReflowInput::CalculateHypotheticalPosition().

However, nsVideoFrame doesn't override nsIFrame::GetIntrinsicSize(), so similar to bug 1104354, I'd like to add it in this bug. Also, I have patches to clean up how video frame's handle intrinsic size and ratio.

Also, delete unused rendering context parameter for
GetVideoIntrinsicSize().

Depends on D95578

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6a41afb9bbc3
Part 1 - Improve type safety for APIs computing video's intrinsic size and ratio. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0d59a429a743
Part 2 - Use strong types to define fallback intrinsic width, height, and size. r=emilio
https://hg.mozilla.org/integration/autoland/rev/5f6ae351d7cc
Part 3 - Add GetIntrinsicSize() override for nsVideoFrame. r=emilio
Severity: -- → S3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: