1674922 - Cleanup Http3Session::ReadSegments and add tests

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Cleanup ReadSegments:

• Move looping while calling mTransaction->ReadSegments into Http3Stream and call mTransaction->ReadSegmentsAgain. We use to loop in Http3Session which was not easy because it is not easy to find out when to leave the loop. The original code was working, but this is a better way to do this.
• Remove mReadyForWriteButBlocked it is not necessary, it was used only as a double check and can only be a source of bugs.
• Remove mContentBytesWritten, because it is not used.
• Http3Server now reads post data and returns amount of data received (this was needed to make better test).
• In test_http3.js increase the number of parallel to trigger max-concurent-stream limit and test stream queuing before streams being activated.
• Add tests for post with large amount of data that are hitting the stream bugger limits. This is testing Http3Event::Tag::DataWritable and also testing the the end of the mTransaction->ReadSegmentsAgain loop.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058e2449bbac
Cleanup ReadSegments: r=necko-reviewers,kershaw

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/058e2449bbac