1674947 - warning: getting the inner pointer of a temporary `CString`

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

Recent rustc nightlies show this new warning:

warning: getting the inner pointer of a temporary `CString`
  --> xpcom/rust/gtest/nsstring/test.rs:15:56
   |
15 |         GTest_ExpectFailure(CString::new(msg).unwrap().as_ptr());
   |                             -------------------------- ^^^^^^ this pointer will be invalid
   |                             |
   |                             this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
   |
   = note: `#[warn(temporary_cstring_as_ptr)]` on by default
   = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1674947 - Fix warning: getting the inner pointer of a temporary `CString`.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d327d86e598
Fix warning: getting the inner pointer of a temporary `CString`. r=xpcom-reviewers,nika

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2d327d86e598