1674948 - Intermittent browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Toolbar should not become visible when loading slow site -

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=320519283&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/X-kkdRaaS9iliS-VwFOnVQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/X-kkdRaaS9iliS-VwFOnVQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2020-11-02T22:20:11.945Z] 22:20:11     INFO - TEST-START | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js
[task 2020-11-02T22:20:12.236Z] 22:20:12     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x11c1ed000 == 8 [pid = 2218] [id = 7]
[task 2020-11-02T22:20:12.236Z] 22:20:12     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (0x14967b740) [pid = 2218] [serial = 15] [outer = 0x0]
[task 2020-11-02T22:20:12.236Z] 22:20:12     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x11c1ef400) [pid = 2218] [serial = 16] [outer = 0x14967b740]
[task 2020-11-02T22:20:12.346Z] 22:20:12     INFO - GECKO(2218) | [Parent 2218, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4282
[task 2020-11-02T22:20:13.257Z] 22:20:13     INFO - TEST-INFO | started process screencapture
[task 2020-11-02T22:20:13.394Z] 22:20:13     INFO - TEST-INFO | screencapture: exit 0
[task 2020-11-02T22:20:13.394Z] 22:20:13     INFO - Buffered messages logged at 22:20:11
[task 2020-11-02T22:20:13.394Z] 22:20:13     INFO - Entering test bound bookmarks_toolbar_shown_on_newtab
[task 2020-11-02T22:20:13.394Z] 22:20:13     INFO - Testing with the feature enabled and newtab enabled
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Buffered messages finished
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Toolbar should not become visible when loading slow site - 
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Stack trace:
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochitests/content/browser/browser/base/content/test/about/head.js:waitForBookmarksToolbarVisibilityWithExitConditions:272
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | The bookmarks toolbar should not become visible before the site is loaded - 
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Stack trace:
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochitests/content/browser/browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js:bookmarks_toolbar_shown_on_newtab:48
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Toolbar hidden on slow site - 
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - Stack trace:
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-02T22:20:13.395Z] 22:20:13     INFO - chrome://mochitests/content/browser/browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js:bookmarks_toolbar_shown_on_newtab:52
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Uncaught exception - at resource://testing-common/BrowserTestUtils.jsm:1099 - TypeError: can't access property "browsers", win.gBrowser is undefined
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - Stack trace:
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - windowClosed/finalMsgsPromise<@resource://testing-common/BrowserTestUtils.jsm:1099:26
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - windowClosed@resource://testing-common/BrowserTestUtils.jsm:1098:30
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - closeWindow@resource://testing-common/BrowserTestUtils.jsm:1076:42
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - bookmarks_toolbar_shown_on_newtab@chrome://mochitests/content/browser/browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js:54:30
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - Leaving test bound bookmarks_toolbar_shown_on_newtab
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x152de0800 == 9 [pid = 2218] [id = 8]
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0x14e9dec80) [pid = 2218] [serial = 17] [outer = 0x0]
[task 2020-11-02T22:20:13.396Z] 22:20:13     INFO - GECKO(2218) | [Parent 2218, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:347
[task 2020-11-02T22:20:13.612Z] 22:20:13     INFO - GECKO(2218) | [Child 2220: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x109e0b000 == 2 [pid = 2220] [id = 1]
[task 2020-11-02T22:20:13.612Z] 22:20:13     INFO - GECKO(2218) | [Child 2220: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x11cd02580) [pid = 2220] [serial = 5] [outer = 0x0]
[task 2020-11-02T22:20:13.613Z] 22:20:13     INFO - GECKO(2218) | [Child 2220: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x109e0c400) [pid = 2220] [serial = 6] [outer = 0x11cd02580]
[task 2020-11-02T22:20:14.396Z] 22:20:14     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 18 (0x1091cc000) [pid = 2218] [serial = 18] [outer = 0x14e9dec80]
[task 2020-11-02T22:20:14.533Z] 22:20:14     INFO - GECKO(2218) | [Parent 2218, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:36
[task 2020-11-02T22:20:14.716Z] 22:20:14     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-11-02T22:20:14.716Z] 22:20:14     INFO - Version: 2.1 INTEL-12.9.22
[task 2020-11-02T22:20:14.716Z] 22:20:14     INFO - Vendor: Intel Inc.
[task 2020-11-02T22:20:14.716Z] 22:20:14     INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-11-02T22:20:14.716Z] 22:20:14     INFO - FBO Texture Target: TEXTURE_2D
[task 2020-11-02T22:20:15.079Z] 22:20:15     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11c1ed400 == 8 [pid = 2218] [id = 4] [url = about:blank]
[task 2020-11-02T22:20:15.079Z] 22:20:15     INFO - GECKO(2218) | [Parent 2218: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11c1ec400 == 7 [pid = 2218] [id = 5] [url = about:blank]
[task 2020-11-02T22:20:15.494Z] 22:20:15     INFO - GECKO(2218) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2020-11-02T22:20:15.494Z] 22:20:15     INFO - GECKO(2218) | MEMORY STAT | vsize 7545MB | residentFast 291MB | heapAllocated 104MB
[task 2020-11-02T22:20:15.494Z] 22:20:15     INFO - TEST-OK | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | took 3544ms```

Comment 1

[Alexandru Michis [:malexandru]]

Started appearing on tier 1 jobs:
https://treeherder.mozilla.org/logviewer?job_id=320557490&repo=autoland&lineNumber=3738

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1673363

Comment 3

[:Gijs (he/him)]

Jared, looks like a regression from the changes in 1673363. :-(

Comment 4

[Intermittent Failures Robot]

21 failures in 4128 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 18
• mozilla-central: 2
• try: 1

Platform breakdown:

• macosx1014-64: 2
• linux1804-64: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1674948&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 5

[:Gijs (he/him)]

Looks like maybe this was fixed yesterday (?). Must admit I don't fully understand why...

Comment 6

[:Gijs (he/him)]

Looks like this has disappeared in lieu of bug 1676326. Maybe worth keeping this open until that one is fixed to see if this one comes back...

Comment 7

[Intermittent Failures Robot]

17 failures in 4040 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10
• mozilla-central: 3
• try: 4

Platform breakdown:

• linux1804-64: 13
• linux1804-64-tsan: 2
• windows10-64-shippable-qr: 1
• linux1804-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-11-09&endday=2020-11-15&tree=all

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Clearing needinfo since this is a really low rate of failure.

Comment 9

[Intermittent Failures Robot]

12 failures in 4810 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• try: 1
• autoland: 10

Platform breakdown:

• linux1804-64: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-11-16&endday=2020-11-22&tree=all

Comment 10

[Intermittent Failures Robot]

5 failures in 1479 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 2
• try: 1

Platform breakdown:

• linux1804-64: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-11-23&endday=2020-11-29&tree=all

Comment 11

[Christian Holler (:decoder)]

Fwiw, this is essentially a perma failure on Fission combined with TSan.

Comment 12

[Intermittent Failures Robot]

6 failures in 3712 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 2
• try: 1

Platform breakdown:

• linux1804-64: 5
• linux1804-64-tsan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-11-30&endday=2020-12-06&tree=all

Comment 13

[Intermittent Failures Robot]

4 failures in 4060 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• try: 2
• mozilla-release: 1

Platform breakdown:

• macosx1014-64-qr: 1
• linux1804-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-12-07&endday=2020-12-13&tree=all

Comment 14

[Intermittent Failures Robot]

1 failures in 3421 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-12-14&endday=2020-12-20&tree=all

Comment 15

[Intermittent Failures Robot]

3 failures in 1450 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 1

Platform breakdown:

• linux1804-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-12-21&endday=2020-12-27&tree=all

Comment 16

[Intermittent Failures Robot]

2 failures in 525 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• linux1804-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2020-12-28&endday=2021-01-03&tree=all

Comment 17

[Chris Peterson [:cpeterson]]

(In reply to Christian Holler (:decoder) from comment #11)

Fwiw, this is essentially a perma failure on Fission combined with TSan.

This test is skipped for fission && tsan. Sending to Fission triage to decide whether this bug should block Fission Beta.

[browser_aboutNewTab_bookmarksToolbarNewWindow.js]
skip-if = fission && tsan # Bug 1674948, perma on Fission+TSan

https://searchfox.org/mozilla-central/rev/519f913527b0d9d5097d290d5731cff6b2991fe0/browser/base/content/test/about/browser.ini#39-40

Comment 18

[Intermittent Failures Robot]

5 failures in 2956 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 2

Platform breakdown:

• linux1804-64: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2021-01-04&endday=2021-01-10&tree=all

Comment 19

[Chris Peterson [:cpeterson]]

@ Jared, can you recommend a frontend developer that has time to debug this browser_aboutNewTab_bookmarksToolbarNewWindow.js test's perma timeout with Fission? Or do you think this perma test timeout doesn't need to block shipping Fission MVP?

Looks like a test timing issue when testing slow-loading sites, not a TSan assertion failure. That's good news.

Nika says this test's slow-loading page's delay is before HTTP response headers are sent, so Fission process switching will not have occurred yet. Is Fission making the slow-loading site even slower than expected?

Comment 20

[Jared Wein [:jaws] (please needinfo? me)]

Sam, could you look in to this?

Comment 21

[Sam Foster [:sfoster] (he/him)]

Yeah I can take a look.

Comment 22

[Intermittent Failures Robot]

4 failures in 3810 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• try: 1

Platform breakdown:

• linux1804-64: 2
• linux1804-64-tsan: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2021-01-11&endday=2021-01-17&tree=all

Comment 23

[Chris Peterson [:cpeterson]]

Tracking Fission test failures for Fission M7 Beta

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 25

[Sam Foster [:sfoster] (he/him)]

Is it possible to repro this without all the tsan tooling and a local tsan build? I've tried downloading the build from https://firefox-source-docs.mozilla.org/tools/sanitizer/tsan.html, and running the test with --appname /path/to/the/tsan/firefox-bin, but that gives me a certificate error.

(In reply to Chris Peterson [:cpeterson] from comment #19)

Nika says this test's slow-loading page's delay is before HTTP response headers are sent, so Fission process switching will not have occurred yet. Is Fission making the slow-loading site even slower than expected?

I can try moving the timer in that slow_loading_page.sjs, so it better emulates a laggy response. But, if that fixes the test under tsan+fission, is that really a fix? That seems like fixing a symptom, not the cause.

Comment 26

[Sam Foster [:sfoster] (he/him)]

Ok I've been able to reproduce this locally using --verify, so I've got something to work with. It would still be good to know how to get this test to run in the same way on Try.

Comment 27

[Intermittent Failures Robot]

7 failures in 3488 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64: 6
  • debug: 6
• linux1804-64-tsan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2021-01-18&endday=2021-01-24&tree=all

Comment 28

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1674948 - Refactor browser_aboutNewTab_bookmarksToolbarNewWindow.js test; observe toolbar mutations to ensure it starts and remains collapsed on each test case. r?Gijs!

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e308f1c333cb
Refactor browser_aboutNewTab_bookmarksToolbarNewWindow.js test; observe toolbar mutations to ensure it starts and remains collapsed on each test case. r=Gijs

Comment 30

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e308f1c333cb

Comment 31

[Intermittent Failures Robot]

2 failures in 3891 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform and build breakdown:

• linux1804-64: 1
  • debug: 1
• macosx1014-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2021-01-25&endday=2021-01-31&tree=all

Comment 32

[Intermittent Failures Robot]

1 failures in 4322 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1674948&startday=2021-02-08&endday=2021-02-14&tree=all