1675050 - "Sponsored Top Sites" checkbox shouldn't need a restart to show up after setting browser.topsites.useRemoteSetting=true

Status: VERIFIED FIXED

(Firefox :: Top Sites, defect, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1675050 - "Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e8f84c8ec0
"Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 81e8f84c8ec0 (bug 1675050) for Newtab failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=320755953&repo=autoland&lineNumber=273

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=81e8f84c8ec04bf67cef598e7643851368eaa2fe

Backout:
https://hg.mozilla.org/integration/autoland/rev/231d48c3fc6bfa3429be1ac742ab7939e47cd83b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbc6afc7db11
"Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dbc6afc7db11

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9185522 [details]
Bug 1675050 - "Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: As part of an upcoming experiment in Firefox 83 that will enable browser.topsites.useRemoteSetting, it's expected that users can disable sponsored about:newtab tiles by unchecking the "Sponsored Top Sites" checkbox in about:preferences#home.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: set browser.topsites.useRemoteSetting to true in about:config, then open about:preferences#home and find the "Sponsonred Top Sites" checkbox
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed: -

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9185522 [details]
Bug 1675050 - "Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer

Uplift approved for our last beta, thanks.

Comment 8

[Julien Cristau [:jcristau] (back on 2026-01-06)]

I'm hitting conflicts in browser/components/newtab/karma.mc.config.js when applying this on beta

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch for uplift

Comment 10

[Julien Cristau [:jcristau] (back on 2026-01-06)]

https://hg.mozilla.org/releases/mozilla-beta/rev/266fdd3059d4

Comment 11

[Petruta Horea [:phorea]]

Verified using Firefox 83 beta 10 and latest Nightly 84.0a1 2020-11-09 under Win 10 x64 and Ubuntu 18.04 x64 that the browser doesn't need a restart for "Sponsored Top Sites" checkbox to be shown in about:preferences#home when switching browser.topsites.useRemoteSetting to True.

However, if Preferences page is already opened, it needs to be refreshed in order for the checkbox to be displayed. :dao, is this intended or should I file a follow-up? I only compared it with browser.newtabpage.activity-stream.showSearch checkbox that it's instantly checked/unchecked on about:preferences page. Thank you!

Comment 12

[Dão Gottwald [:dao]]

(In reply to Petruta Horea [:phorea] from comment #11)

However, if Preferences page is already opened, it needs to be refreshed in order for the checkbox to be displayed. :dao, is this intended or should I file a follow-up? I only compared it with browser.newtabpage.activity-stream.showSearch checkbox that it's instantly checked/unchecked on about:preferences page. Thank you!

This is fine as is.

Comment 13

[Petruta Horea [:phorea]]

Thanks!
Marking as verified based on above comments.