Closed Bug 1675054 Opened 4 years ago Closed 3 years ago

Enable brotli encoding in secure context, not just for https

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: djc, Assigned: valentin)

References

Details

(Keywords: perf-alert, Whiteboard: [necko-triaged])

Attachments

(1 file)

As dicussed in #necko. (Not sure if enhancement or bug.)

Assignee: nobody → valentin.gosu
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Attachment #9185707 - Attachment description: Bug 1675054 - Enable brotli encoding in secure context, not just for https → Bug 1675054 - Enable brotli encoding for trustworthy URLs, not just for https r=#necko
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a04a58abafff Enable brotli encoding for trustworthy URLs, not just for https r=necko-reviewers,dragana
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Regressions: 1756478
Regressions: 1756556

It seems this has caused a couple of regressions.
I don't have time to investigate it right now, so we'll probably back it out.

Backed out for causing multiple regressions.

Status: RESOLVED → REOPENED
Flags: needinfo?(valentin.gosu)
Resolution: FIXED → ---
Target Milestone: 99 Branch → ---
Regressed by: 1692701
No longer regressed by: 1692701
Regressions: 1692701
Regressions: 1756566
Flags: needinfo?(valentin.gosu)

(In reply to Cristian Tuns from comment #5)

Backed out for causing multiple regressions.

== Change summary for alert #33403 (as of Fri, 25 Feb 2022 14:17:28 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
3292% youtube LastVisualChange macosx1015-64-shippable-qr fission warm webrender 120.00 -> 4,070.00
463% amazon LastVisualChange windows10-64-shippable-qr fission warm webrender 230.46 -> 1,297.25
138% office LastVisualChange windows10-64-shippable-qr cold fission webrender 783.67 -> 1,861.42
122% amazon LastVisualChange windows10-64-shippable-qr cold fission webrender 833.54 -> 1,847.42
93% office LastVisualChange windows10-64-shippable-qr cold fission webrender 971.12 -> 1,877.92
93% cnn-ampstories loadtime android-hw-g5-7-0-arm7-shippable-qr warm webrender 311.75 -> 601.08
65% office ContentfulSpeedIndex windows10-64-shippable-qr fission warm webrender 342.08 -> 565.50
63% facebook loadtime windows10-64-shippable-qr fission warm webrender 254.83 -> 415.79
55% facebook dcf windows10-64-shippable-qr fission warm webrender 253.37 -> 392.62
49% amazon loadtime windows10-64-shippable-qr fission warm webrender 277.19 -> 413.88
... ... ... ... ...
8% office fcp windows10-64-shippable-qr fission warm webrender 354.08 -> 383.96
7% facebook fnbpaint linux1804-64-shippable-qr cold fission webrender 607.47 -> 652.54
7% facebook fnbpaint windows10-64-shippable-qr cold fission webrender 613.80 -> 655.50
7% facebook dcf linux1804-64-shippable-qr cold fission webrender 597.70 -> 636.75
6% facebook dcf windows10-64-shippable-qr cold fission webrender 601.93 -> 635.04

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
87% cnn-ampstories fcp android-hw-g5-7-0-arm7-shippable-qr warm webrender 8,324.66 -> 1,118.17
75% cnn-ampstories fcp android-hw-g5-7-0-arm7-shippable-qr cold webrender 9,366.72 -> 2,385.71

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33403

(In reply to Cristian Tuns from comment #5)

Backed out for causing multiple regressions.

== Change summary for alert #33402 (as of Fri, 25 Feb 2022 14:09:10 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
8% JS windows10-64-2004-shippable-qr tp6 255,934,401.10 -> 276,786,843.76
7% Explicit Memory windows10-64-2004-shippable-qr tp6 655,348,329.26 -> 699,873,722.21
6% Resident Memory windows10-64-2004-shippable-qr tp6 870,987,133.93 -> 926,044,396.58
5% Resident Memory windows10-64-2004-shippable-qr tp6 877,517,750.17 -> 917,938,940.72

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33402

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fc09cf8d7c91 Enable brotli encoding for trustworthy URLs, not just for https r=necko-reviewers,dragana
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
No longer regressions: 1692701
No longer regressions: 1756478
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: