Closed
Bug 1675074
Opened 4 years ago
Closed 4 years ago
Make WellKnownParserAtoms part of the rodata section
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
As a continuation of Bug 1666274, we should make the rest of the well-known ParserAtoms part of the ROM data. This is useful to do after Bug 1668672 which uses a LifoAlloc for these atoms.
|
Assignee | |
Comment 1•4 years ago
|
||
This removes the LifoAlloc from WellKnownParserAtoms and instead using
constexpr to store the atom data in WellKnownParserAtoms_ROM so that this is
all evaluated at startup time and live in read-only memory.
The WellKnownParserAtoms itself still maintains fields and a hash-table that
are not in the ROM, but exist once per JSRuntime.
|
||
Updated•4 years ago
|
Assignee: nobody → tcampbell
Status: NEW → ASSIGNED
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e83e1fece2dd Use constexpr for all well-known ParserAtoms. r=arai
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•