Closed
Bug 1675084
Opened 4 years ago
Closed 4 years ago
Warp: Make transpiled call instructions depend on argument guards
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When we transpile a call, we may also transpile guards on some of the arguments. (For example, we guard that the argument to a funapply is a packed array.) When we generate the actual call node, however, we use the original values of the arguments, not the guarded values. Among other things, this can cause us to insert unnecessary fallible unboxes.
|
Assignee | |
Updated•4 years ago
|
Summary: Warp: Maketranspiled call instructions depend on argument guards → Warp: Make transpiled call instructions depend on argument guards
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c971c088ab13 Ensure call node depends on guards r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•