Closed Bug 1675094 Opened 3 years ago Closed 3 years ago

Replace executeSoon() with waitForTick() in accessible/tests/browser

Categories

(Core :: Disability Access APIs, task)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: hexagonrecursion, Assigned: hexagonrecursion)

Details

Attachments

(1 file)

Bug 1675094 Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie
47 bytes, text/x-phabricator-request
Details | Review

waitForTick() is a more promise-friendly and await-friendly API than executeSoon().
I used the following semgrep rules automatically replace executeSoon() with waitForTick()

rules:
  - id: executeSoon-to-waitForTick       
    patterns:
      - pattern: new Promise(resolve => executeSoon(resolve))
    fix: waitForTick()
    languages: [javascript]
    message: use waitForTick() instead
    severity: WARNING
Assignee: nobody → hexagonrecursion
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c68ab3e8a465
Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie,yzen

https://hg.mozilla.org/mozilla-central/rev/c68ab3e8a465

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox84: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.