167510 - Impossible to unbold selection, CSS mode

Status: RESOLVED FIXED

Description

[Daniel Glazman (:glazou)]

1. launch Composer, in CSS mode
2. type one char
3. click on B button
4. type one char
5. click on B button
5. type one char
6. select the 3 chars
7. click on the B button, that should bolden all the selection
8. click again on the B button

Expected result : unbolds the selection
Actual result : does nothing

Comment 1

[Kathleen :Brade]

Here is the resulting html source (steps 1-5):
<span style="font-weight: bold;">a</span><span
 style="font-weight: bold;">b</span><span style="font-weight: bold;">c</span>

I expect to see:
<span style="font-weight: bold;">abc</span>

Is the lack of consolidation/coalescing covered in this bug or should I file a
new one for that issue?

Comment 2

[Daniel Glazman (:glazou)]

Created attachment 98471 [details] [diff] [review]
first try ;-)

Comment 3

[Kathleen :Brade]

comment 1 appears to be covered by a different bug (on jfrancis' plate)

Comment 4

[Kathleen :Brade]

Comment on attachment 98471 [details] [diff] [review]
first try ;-)

r=brade
 Do we need an assertion for aValueString in
GetCSSEquivalentToHTMLInlineStyleSet?

Comment 5

[Boris Zbarsky [:bz] (Vacation Jun 16-24) (no decent commit message means r-)]

Comment on attachment 98471 [details] [diff] [review]
first try ;-)

sr=bzbarsky

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 98471 [details] [diff] [review]
first try ;-)

a=asa (on behalf of drivers) for checkin to 1.2a. (land quickly or miss the
boat. we're down to the wire)

Comment 7

[Daniel Glazman (:glazou)]

*sigh*... too late

Comment 8

[Daniel Glazman (:glazou)]

checked in trunk