1675241 - Use ParserAtom index in stencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Currently ParserAtoms are referred by pointer inside stencil structure.
If we can replace it with ParserAtom index inside vector (added by bug 1674351),
The struct size and variant size gets reduced, and also we can directly encode the index into XDR buffer.

Comment 1

[Tooru Fujisawa [:arai]]

TODO:

1. Use separate storage for "all frontend atoms" and "atoms used by stencil"
2. Add 28-bit limitation to the number of parser atom
3. Add TaggedAtomIndex that represents all ParserAtom kind in 32-bit
4. Encode/decode "atoms used by stencil" at the beginning, instead of switching between buffer while encoding fields
5. Use TaggedAtomIndex in stencil fields

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 1: Build CompilationStencil.parserAtomData when storing into stencil fields. r?tcampbell!

Now ParserAtomsTable in CompilationState uses different storage than
CompilationStencil.parserAtomData, and when storing a parser atom into
any of stencil field, the atom is copied to CompilationStencil.parserAtomData.

As a result, all atoms inside CompilationStencil.parserAtomData are used by
stencil and allocation/instantiation gets simpler.

This replaces markUsedByStencil with storeIntoStencil, and slightly moves the
callsite, to get access to CompilationInfo.

Later patch will modify storeIntoStencil to return an index, and all
ParserAtom* field will be replaced by the index.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 2: Let storeIntoStencil return TaggedAtomIndex. r?tcampbell!

Also add 28-bit limitation to the number of parser atoms.

Later patch will add null tag, and also move well-known/static1/static2 into
sub tag.

Depends on D96240

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 3: Use TaggedAtomIndex in XDR. r?tcampbell!

Depends on D96241

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 4: Move getWellKnown impl to WellKnownParserAtoms. r?tcampbell!

Depends on D96242

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 5: Encode all ParserAtoms at the beginning in XDRIncrementalStencilEncoder. r?tcampbell!

Depends on D96243

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 6: Add null variant to TaggedAtomIndex. r?tcampbell!

To use index in nullable atom field, add null tag.

Depends on D96244

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 7: Use TaggedAtomIndex in ScriptStencil.functionAtom. r?tcampbell!

Added infrastructure for handling TaggedAtomIndex in stencil instantiation and
encode/decode, and replaced ScriptStencil.functionAtom with TaggedAtomIndex
as an example consumer.

Depends on D96245

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 8: Use TaggedAtomIndex in RegExpStencil.atom_. r?tcampbell!

Depends on D96246

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 9: Use TaggedAtomIndex in StencilModuleEntry. r?tcampbell!

Depends on D96247

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 10: Use TaggedAtomIndex in ScriptThingVariant. r?tcampbell!

Depends on D96248

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 11: Use TaggedAtomIndex in ObjLiteralStencil. r?tcampbell!

Depends on D96249

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 12: Compress tag bits. r?tcampbell!

Depends on D96250

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 1: Build CompilationStencil.parserAtomData when storing into stencil fields. r?tcampbell!

Now ParserAtomsTable doesn't build CompilationStencil.parserAtomData.
CompilationStencil.parserAtomData is built when storing a parser atom into
any of stencil field.

As a result, all atoms inside CompilationStencil.parserAtomData are used by
stencil and allocation/instantiation gets simpler.

This replaces markUsedByStencil with storeIntoStencil, and slightly moves the
callsite, to get access to CompilationInfo.

Later patch will modify storeIntoStencil to return an index, and all
ParserAtom* field will be replaced by the index.

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 1: Move getWellKnown/getStatic1/getStatic2 impl to WellKnownParserAtoms. r?tcampbell!

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 2: Add getWellKnown/getStatic1/getStatic2 to ParserAtomsTable. r?tcampbell!

Depends on D96908

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 3: Add {ParserAtomsTable,ParserAtomVectorBuilder}::getParserAtom. r?tcampbell!

Depends on D96909

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 4: Use TaggedParserAtomIndex in ParserAtomEntry. r?tcampbell!

Depends on D96910

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 5: Use TaggedParserAtomIndex in XDR. r?tcampbell!

Depends on D96911

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 6: Add CompilationAtomCache.getExistingAtomAt with TaggedParserAtomIndex. r?tcampbell!

Depends on D96912

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 7: Add CompilationStencil::getParserAtomAt. r?tcampbell!

Depends on D96913

Comment 22

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 8: Use TaggedParserAtomIndex in ScriptStencil.functionAtom. r?tcampbell!

Depends on D96914

Comment 23

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 9: Use TaggedParserAtomIndex in RegExpStencil.atom_. r?tcampbell!

Depends on D96915

Comment 24

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 10: Use TaggedParserAtomIndex in StencilModuleEntry. r?tcampbell!

Depends on D96916

Comment 25

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 11: Use TaggedParserAtomIndex in ScriptThingVariant. r?tcampbell!

Depends on D96917

Comment 26

[Tooru Fujisawa [:arai]]

Attachment: Bug 1675241 - Part 12: Use TaggedParserAtomIndex in ObjLiteralStencil. r?tcampbell!

Depends on D96918

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0210295f9234
Part 1: Move getWellKnown/getStatic1/getStatic2 impl to WellKnownParserAtoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5e683e6376b9
Part 2: Add getWellKnown/getStatic1/getStatic2 to ParserAtomsTable. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b2dc7bdd01dc
Part 3: Add {ParserAtomsTable,ParserAtomVectorBuilder}::getParserAtom. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f8de842b23db
Part 4: Use TaggedParserAtomIndex in ParserAtomEntry. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5d6e0d22083f
Part 5: Use TaggedParserAtomIndex in XDR. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/50e9d084764c
Part 6: Add CompilationAtomCache.getExistingAtomAt with TaggedParserAtomIndex. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/3749d6d2325d
Part 7: Add CompilationStencil::getParserAtomAt. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f505b8fb8f8b
Part 8: Use TaggedParserAtomIndex in ScriptStencil.functionAtom. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/73cc5fa0e0bd
Part 9: Use TaggedParserAtomIndex in RegExpStencil.atom_. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cb0e58368cd4
Part 10: Use TaggedParserAtomIndex in StencilModuleEntry. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8af30c6d9bb9
Part 11: Use TaggedParserAtomIndex in ScriptThingVariant. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ca60758cd534
Part 12: Use TaggedParserAtomIndex in ObjLiteralStencil. r=tcampbell

Comment 28

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0210295f9234
https://hg.mozilla.org/mozilla-central/rev/5e683e6376b9
https://hg.mozilla.org/mozilla-central/rev/b2dc7bdd01dc
https://hg.mozilla.org/mozilla-central/rev/f8de842b23db
https://hg.mozilla.org/mozilla-central/rev/5d6e0d22083f
https://hg.mozilla.org/mozilla-central/rev/50e9d084764c
https://hg.mozilla.org/mozilla-central/rev/3749d6d2325d
https://hg.mozilla.org/mozilla-central/rev/f505b8fb8f8b
https://hg.mozilla.org/mozilla-central/rev/73cc5fa0e0bd
https://hg.mozilla.org/mozilla-central/rev/cb0e58368cd4
https://hg.mozilla.org/mozilla-central/rev/8af30c6d9bb9
https://hg.mozilla.org/mozilla-central/rev/ca60758cd534