1675466 - using browser's feature to got back one page in history from intermittent failures page for a bug goes to to blank page, second call of 'back' function needed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Using the browser's feature to got back one page (backspace, Back button) in history from an intermittent failures page for a bug goes to to blank page, a second call of the 'back' function is needed.

Example:

1. Open bug 1675436.
2. Use the link near "Orange Factor" in the "Details" header section.
3. Once the page has loaded, hit the Backspace key.

Actual result: Blank page
Expected result: Back to bugzilla page.

Link after going to the Intermittent Failures View:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2020-10-29&endday=2020-11-05&tree=trunk&bug=1675436
Link after hitting Backspace:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-10-29&endday=2020-11-05&tree=trunk&bug=1675436

Comment 1

[Sarah Clements [:sclements]]

This is happening because the urls from bugzilla haven't been updated yet, so when you click on the url with the hash that will be the first entry in the history object, and then once the link is converted to the appropriate hash-free route, another entry is added to the history object. I could probably replace that first entry with the new one (instead of using push), but those urls in bugzilla need to be updated regardless. Do you happen to recall who is managing the Orange Factor component?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: GitHub Pull Request

Comment 3

[Sarah Clements [:sclements]]

Comment on attachment 9186310 [details] [review]
GitHub Pull Request

LGTM. Thanks Aryx!

Comment 4

[David Lawrence [:dkl]]

Merged to master.