1675484 - iframe.onfocus invoked upon iframe.focus() for out-of-process iframes

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

When calling iframe.focus() on an OOP iframe, Chrome and Fission invoke iframe.onfocus. However, we don't invoke it for in-process iframes. Test case coming up in bug 1662772.

Comment 1

[Edgar Chen [:edgar]]

It seems like the difference is probably from the elementToFocus and newWindow setup in nsFocusManager::SetFocusInner,

• In-process iframe case: the newWindow would be the contentWindow of iframe, and elementToFocus would be the mFocusedElement in contentWindow.
• OOP iframe case: the newWindow would be the window that contains the iframe, and elementToFocus would be the iframe itself.

Comment 2

[Henri Sivonen (:hsivonen)]

Per discussion with Anne, spec-wise this looks like a Fission (and partially Blink) bug after all, and there's no spec basis for the event firing. (We should also consider the possibility that something expects the event to fire as in Blink compat-wise by now.)

Comment 3

[Neha Kochar [:neha]]

Moving it to MVP since the current behavior is the same as Chrome.

Comment 4

[Neha Kochar [:neha]]

We should be able to fix this sooner in M8.

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea907a825e58936c67f9312f0ea258506d2bd8f1

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=042788760bd48249e45b4a068d4cb175e214f617

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1675484 - iframe.onfocus should not be invoked when focus moves to out-of-process iframes; r=hsivonen

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab57f439bce3
iframe.onfocus should not be invoked when focus moves to out-of-process iframes; r=hsivonen

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ab57f439bce3