Closed Bug 1675504 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26413 - [scroll-animations] Handle implicit 'auto' offsets correctly

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26413
Details from upstream follow.

b'Anders Hartvoll Ruud <andruud@chromium.org>' wrote:

[scroll-animations] Handle implicit 'auto' offsets correctly

We currently don't handle that case where start/end offsets are
nullptr correctly. In this case they should behave as 'auto'. Possibly
a regression from the scrollOffsets implementation.

Fixed: 1145916
Bug: 1074052
Change-Id: Ib97e1157b957dc2de4393688967694fc9b0de736
Reviewed-on: https://chromium-review.googlesource.com/2520836
WPT-Export-Revision: b24c213298cc008a10f034c64e3b5c7d0ad2bbb6

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 61 subtests

Status Summary

Firefox

OK : 1
PASS: 6
FAIL: 39

Chrome

OK : 1
PASS: 41
FAIL: 4

Safari

OK : 1
PASS: 6
FAIL: 39

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/css/at-scroll-timeline-start-end.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Scroll at offset 1 updates animation correctly [element_0px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 50 updates animation correctly [element_0px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 99 updates animation correctly [element_0px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 100 updates animation correctly [element_0px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 101 updates animation correctly [element_0px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 0 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 1 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 49 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 51 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 99 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 100 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 101 updates animation correctly [element_50px_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 21 updates animation correctly [element_auto_auto]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 21 updates animation correctly [element_auto_auto_implicit]: FAIL (Chrome: FAIL, Safari: FAIL)
Scroll at offset 0 updates animation correctly [element_50px_auto]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 49 updates animation correctly [element_50px_auto]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 1 updates animation correctly [element_auto_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 50 updates animation correctly [element_auto_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 99 updates animation correctly [element_auto_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 100 updates animation correctly [element_auto_100px]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 0 updates animation correctly [element_25p_75p]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 21 updates animation correctly [element_25p_75p]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 63 updates animation correctly [element_calc_calc]: FAIL (Chrome: PASS, Safari: FAIL)
Scroll at offset 106 updates animation correctly [element_auto_auto]: FAIL
Scroll at offset 190 updates animation correctly [element_auto_auto]: FAIL
Scroll at offset 212 updates animation correctly [element_auto_auto]: FAIL
Scroll at offset 106 updates animation correctly [element_auto_auto_implicit]: FAIL
Scroll at offset 190 updates animation correctly [element_auto_auto_implicit]: FAIL
Scroll at offset 212 updates animation correctly [element_auto_auto_implicit]: FAIL
Scroll at offset 131 updates animation correctly [element_50px_auto]: FAIL
Scroll at offset 195 updates animation correctly [element_50px_auto]: FAIL
Scroll at offset 212 updates animation correctly [element_50px_auto]: FAIL
Scroll at offset 42 updates animation correctly [element_25p_75p]: FAIL
Scroll at offset 74 updates animation correctly [element_25p_75p]: FAIL
Scroll at offset 116 updates animation correctly [element_25p_75p]: FAIL
Scroll at offset 169 updates animation correctly [element_25p_75p]: FAIL
Scroll at offset 212 updates animation correctly [element_25p_75p]: FAIL
Scroll at offset 116 updates animation correctly [element_calc_calc]: FAIL
Scroll at offset 179 updates animation correctly [element_calc_calc]: FAIL

Tests Disabled in Gecko Infrastructure

/scroll-animations/css/at-scroll-timeline-start-end.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a81d9d2b72b1 [wpt PR 26413] - [scroll-animations] Handle implicit 'auto' offsets correctly, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a81d9d2b72b1

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.