1675636 - Change cancel button text to close after print starts

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Mark Striemer [:mstriemer]]

When a print is started Cancel button in the print settings pane can be clicked to close the dialog, but it will only close the dialog, not cancel the print.

The button should either cancel the print or have its text changed to something like "Close" so it doesn't look like it will cancel the print.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I'll go with switching the cancel button to "Close" when printing begins.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Bumping to 85 because it's a string change.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1675636 - Switch cancel button label to 'close' while printing. r?mstriemer!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea6d1c8d5dd9
Switch cancel button label to 'close' while printing. r=mstriemer,fluent-reviewers

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ea6d1c8d5dd9

Comment 6

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

This issue is verified fixed using Firefox 85.0b5 (BuildId:20210105180113) and Firefox 86.0a1 (BuildId:20210106155127) on Windows 10 64bit, macOS 10.15.7 & Ubuntu 20.04.