1675640 - Rename our internal FirstContentfulPaint to FirstContentfulComposite

Status: RESOLVED FIXED

(Core :: Performance, enhancement, P3)

Description

[Sean Feng [:sefeng]]

After bug 1518999, now we have two versions of first contentful paint. We should rename the old one to FirstContentfulComposite.

Comment 1

[achmurali]

Hi sefeng,

Would love to pick this bug.
I have looked at the revision for bug 1518999, but wasn't able to figure out the files which are carrying the older version of
"FirstContentfulPaint" i.e. which are to be renamed to "FirstContentfulComposite".
Could you please help me out. :D

Thanks

Comment 2

[Sean Feng [:sefeng]]

Hey, most of the things that need to be changed are in https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/dom/base/nsDOMNavigationTiming.cpp#441. There's a string literal "FirstContentfulPaint" in this method, which is being used as the name of the marker, so this needs to be changed. Also the function name and the mContentfulPaint member variable.

Does that help?

Comment 3

[achmurali]

Attachment: Bug 1675640 - Renaming internal FirstContentfulPaint to FirstContentfulComposite

Renaming older versions of FirstContentfulPaint - literal,variables and method to FirstContentfulComposite

Depends on D109655

Comment 4

[achmurali]

Thanks for the gui(In reply to Sean Feng [:sefeng] from comment #2)

Hey, most of the things that need to be changed are in https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/dom/base/nsDOMNavigationTiming.cpp#441. There's a string literal "FirstContentfulPaint" in this method, which is being used as the name of the marker, so this needs to be changed. Also the function name and the mContentfulPaint member variable.

Does that help?

Yes sefeng, it did help a lot.
Thanks for the information.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Surajeet Das]

Can anyone explain me the bug ?

Comment 7

[achmurali]

Hi sefeng,

Sorry for the delay, was down with a bad fever. Thanks for bearing with me :D.

I have updated the patch with the suggested changes.
Could you also kindly help me figure out with the bug you have mentioned "Make TTI/TTFI to use first-contentful-paint instead of contentful composite".

Lastly, i see that there is a Bug 1691820 dependent on this bug, please let me know if can work on it :D.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:murali.venkata4, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60b737e0dbfb
Renaming internal FirstContentfulPaint to FirstContentfulComposite r=sefeng,mstange

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/60b737e0dbfb