1675643 - Cookie AutoDelete localStorage cleanup throws when dom.storage.next_gen is false

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[gwarser]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

• dom.storage.next_gen option set to false.
• Installed https://addons.mozilla.org/firefox/addon/cookie-autodelete/
• Option "Enable Automatic Cleaning" checked.
• Option "Enable LocalStorage Cleanup" checked.
• Probably "Enable Support for Firefox's Container Tabs" option also needs to be enabled, or must be enabled only on first try
• Open few pages in tabs. Sample pages: https://www.youtube.com/ https://www.wykop.pl/ https://allegro.pl/
• Close them
• wait for cleaning to be triggered - 15s by default

Actual results:

"Error! An unexpected error occurred" notification is displayed. Debugger shows that something throws in code, but is catched.

mozregression points to https://bugzilla.mozilla.org/show_bug.cgi?id=1670811

Expected results:

Storage cleaned successfully, no error notifications.

Comment 1

[gwarser]

26:34.74 INFO: Running autoland build built on 2020-11-03 19:45:20, revision 12e386f1
26:47.08 INFO: Launching /tmp/tmp7ck8w5a5/firefox/firefox
26:47.08 INFO: Application command: /tmp/tmp7ck8w5a5/firefox/firefox --allow-downgrade --allow-downgrade -profile /home/rdk/.mozilla/firefox/4gucti37.dev-edition-default
26:47.09 INFO: application_buildid: 20201103183559
26:47.09 INFO: application_changeset: 12e386f1f5413415698dddd8cce87b00086b1279
26:47.09 INFO: application_name: Firefox
26:47.09 INFO: application_repository: https://hg.mozilla.org/integration/autoland
26:47.09 INFO: application_version: 84.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): bad
27:34.40 INFO: Narrowed integration regression window from [0db0e6a3, a0678795] (3 builds) to [0db0e6a3, 12e386f1] (2 builds) (~1 steps left)
27:34.40 INFO: No more integration revisions, bisection finished.
27:34.40 INFO: Last good revision: 0db0e6a3f8f01d3060adeaaa0aa599b169811f24
27:34.40 INFO: First bad revision: 12e386f1f5413415698dddd8cce87b00086b1279
27:34.40 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0db0e6a3f8f01d3060adeaaa0aa599b169811f24&tochange=12e386f1f5413415698dddd8cce87b00086b1279

Comment 2

[gwarser]

Issue filed on add-on issue tracker: https://github.com/Cookie-AutoDelete/Cookie-AutoDelete/issues/959

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1675643. Fix browsingData.removeLocalStorage when next-gen storage is disabled. r?rpl

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1670811

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb7fef18864
Fix browsingData.removeLocalStorage when next-gen storage is disabled. r=rpl

Comment 6

[Tom S. (please needinfo tschuster)]

Thanks for your report. The central-as-beta would maybe have caught this as well. I am not sure if that counts as early beta. Writing a test for this directly turns out to me a bit difficult because we need to set dom.storage.next_gen during startup.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The central-as-late-beta simulation caught this today, but gwarser was faster. Late beta sims have been reduced to two runs per week.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bdb7fef18864