1675660 - Permanent private browsing new tab pages should have a consistent tab title (either always "New Tab" or always "Private Browsing")

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Screenshot from 2020-11-06 01-43-01.png

Tested using Nightly on Linux

• Create a new Firefox profile
• In the settings set history to "Never remember history"
• Firefox will restart.
• Note the first tab has title "New Tab". It seems to be temporarily "Private Browsing" before switching to "New Tab"

If one very quickly after start creates more tabs (ctrl+t), all those tabs get "New Tab".
Only after some time tabs start to get "Private Browsing" as the title

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This is an opposite of bug 1427186?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Oh, it is even weirder. After there has been "Private Browsing" tabs, one may get more "New Tab"s by creating and removing
tabs quickly.

Comment 3

[:Gijs (he/him)]

Before bug 1353013, the tab title was always "New Tab".

Now, it appears that for preloaded tabs it is "Private Browsing", and otherwise it is "New Tab".

If you turn off preloading (browser.newtab.preload) all tabs go back to being "New Tab".

We probably need an exception in the preloading code to use "New Tab" for permanent private browsing windows, too.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Or if https://searchfox.org/mozilla-central/rev/2fcab997046ba9e068c5391dc7d8848e121d84f8/browser/base/content/tabbrowser-tabs.js#62-65 used non-private browsing title for pb profile, this would work too.
(It is a bit error prone that in some cases the title 'New Tab' comes from the page and some cases from tabbrowser-tabs.js)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1675660 - Permanent private browsing new tab pages should have a consistent tab title (either always 'New Tab' or always 'Private Browsing'), r=Gijs

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd9437abac50dd7524518788cebbc5df5b389eb4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d945e153f6
Permanent private browsing new tab pages should have a consistent tab title (either always 'New Tab' or always 'Private Browsing'), r=Gijs

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e4d945e153f6