Closed Bug 1675660 Opened 4 years ago Closed 4 years ago

Permanent private browsing new tab pages should have a consistent tab title (either always "New Tab" or always "Private Browsing")

Categories

(Firefox :: Private Browsing, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Tested using Nightly on Linux

  • Create a new Firefox profile
  • In the settings set history to "Never remember history"
  • Firefox will restart.
  • Note the first tab has title "New Tab". It seems to be temporarily "Private Browsing" before switching to "New Tab"

If one very quickly after start creates more tabs (ctrl+t), all those tabs get "New Tab".
Only after some time tabs start to get "Private Browsing" as the title

This is an opposite of bug 1427186?

Oh, it is even weirder. After there has been "Private Browsing" tabs, one may get more "New Tab"s by creating and removing
tabs quickly.

Priority: -- → P3

Before bug 1353013, the tab title was always "New Tab".

Now, it appears that for preloaded tabs it is "Private Browsing", and otherwise it is "New Tab".

If you turn off preloading (browser.newtab.preload) all tabs go back to being "New Tab".

We probably need an exception in the preloading code to use "New Tab" for permanent private browsing windows, too.

Severity: -- → S4
Keywords: regression
OS: Unspecified → All
Regressed by: 1353013
Hardware: Unspecified → Desktop
Summary: Private browsing profile shows first (or more) tabs as "new tab", not "Private browsing" → Permanent private browsing new tab pages should have a consistent tab title (either always "New Tab" or always "Private Browsing")
Has Regression Range: --- → yes

Or if https://searchfox.org/mozilla-central/rev/2fcab997046ba9e068c5391dc7d8848e121d84f8/browser/base/content/tabbrowser-tabs.js#62-65 used non-private browsing title for pb profile, this would work too.
(It is a bit error prone that in some cases the title 'New Tab' comes from the page and some cases from tabbrowser-tabs.js)

Assignee: nobody → bugs
Status: NEW → ASSIGNED
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4d945e153f6
Permanent private browsing new tab pages should have a consistent tab title (either always 'New Tab' or always 'Private Browsing'), r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: