Closed Bug 1675707 Opened 4 years ago Closed 4 years ago

symbols_archive.py fails on macos CI

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files)

It fails to find zstandard for subtle reasons.

This allows PATH not to be altered such that python would resolve to
the virtualenv python.

When the virtualenv is activated, subprocesses of mozharness inherit the
PATH that it sets, making plain python resolve to the virtualenv python,
which is actually not desirable for builds.

Ideally, we'd avoid creating a virtualenv for mozharness entirely,
especially considering it creates its own, and then the build creates
yet another one, but that doesn't work because of PYTHONPATH interfering
with the build virtualenv.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/3fb949f2b953
Allow not to activate the virtualenv when running mach python. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/d60240112dab
Don't activate the virtualenv when running mozharness. r=firefox-build-system-reviewers,mhentges
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: