1675858 - Misleading log: Reading manifest: Invalid extension permission: geckoViewAddons

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

When running a privileged extension with the geckoViewAddons we get this log statement:

Reading manifest: Invalid extension permission: geckoViewAddons

Even though the permission is applied and everything works correctly. We should remove it since it's very confusing to embedders.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

This is not specific to Android actually, it happens for all privileged permissions (including mozillaAddons)

Comment 2

[Shane Caraveo (:mixedpuppy)]

Luca will look into doing something about this. It's harmless but annoying.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1675858 - Skip misleading invalid permission warning for privileged permissions while loading manifest from ExtensionData instances. r?mixedpuppy!

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attached a patch which includes:

• some small enough changes to prevent the invalid permission warning to be collected while loading the manifest (when the manifest is parsed by a plain ExtensionData instance, as used in XPIProvider to load and parse the manifest).
• still collect and log as expected the invalid permission warning for the privileged permission when the manifest is being parsed by the Extension class instance
• new test coverage to cover the behavior expected by a ExtensionData class instance and a privileged and non privileged Extension class instances

Pushed to try to double-check that none of the existing tests did break with the changes applied:

• https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f54cc80f58f5708ad2c656492f2b6f913a8027e

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1675858 - Remove misleading obsolete inline comment from Extension.jsm. r?mixedpuppy!

Depends on D97646

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75fa36750ac3
Skip misleading invalid permission warning for privileged permissions while loading manifest from ExtensionData instances. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/18fcdf3ec3f6
Remove misleading obsolete inline comment from Extension.jsm. r=mixedpuppy

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/75fa36750ac3
https://hg.mozilla.org/mozilla-central/rev/18fcdf3ec3f6