1675876 - MOZ_RELEASE_ASSERT(mBuffer != nullptr) Crash in [@ mozilla::wr::RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Chris Peterson [:cpeterson]]

Maybe Fission related. (DOMFissionEnabled=1)

I hit this crash today. Looks like my crash report is the first and only one for this signature.

Crash report: https://crash-stats.mozilla.org/report/index/9100617b-834a-404e-b0bf-aa2710201106

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mBuffer != nullptr)

Top 10 frames of crashing thread:

0 xul.dll mozilla::wr::RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL gfx/webrender_bindings/RenderBufferTextureHostSWGL.cpp:23
1 xul.dll mozilla::layers::BufferTextureHost::CreateRenderTexture gfx/layers/composite/TextureHost.cpp:684
2 xul.dll mozilla::layers::TextureHost::EnsureRenderTexture gfx/layers/composite/TextureHost.cpp:520
3 xul.dll mozilla::layers::WebRenderTextureHost::GetExternalImageKey gfx/layers/wr/WebRenderTextureHost.cpp:61
4 xul.dll mozilla::layers::WebRenderTextureHost::PrepareForUse gfx/layers/wr/WebRenderTextureHost.cpp:168
5 xul.dll mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate gfx/layers/ipc/CompositableTransactionParent.cpp:170
6 xul.dll mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate gfx/layers/ipc/CompositableTransactionParent.cpp:74
7 xul.dll mozilla::layers::WebRenderBridgeParent::ProcessWebRenderParentCommands gfx/layers/wr/WebRenderBridgeParent.cpp:1412
8 xul.dll mozilla::layers::WebRenderBridgeParent::ProcessDisplayListData gfx/layers/wr/WebRenderBridgeParent.cpp:1112
9 xul.dll mozilla::layers::WebRenderBridgeParent::RecvSetDisplayList gfx/layers/wr/WebRenderBridgeParent.cpp:1165

Comment 1

[Dzmitry Malyshau [:kvark]]

Marking as S3 since we aren't shipping SW-WR yet.

Comment 2

[Sotaro Ikeda [:sotaro]]

All crashe reports had "Failed to create a valid ShmemTextureHost" gfxCriticalNote. It might be related.

The ShmemTextureHost failure happened on 32bit Win PCs.

Comment 3

[Sotaro Ikeda [:sotaro]]

RenderBufferTextureHost and RenderExternalTextureHost handle the ShmemTextureHost failure by returning InvalidToWrExternalImage().

• https://searchfox.org/mozilla-central/rev/4f07d49f1c7a823da07e3a231ac87c6435c8fd58/gfx/webrender_bindings/RenderBufferTextureHost.cpp#53

Comment 4

[Sotaro Ikeda [:sotaro]]

RenderTextureHostSWGL::LockSWGL() also has similar implementation.

• https://searchfox.org/mozilla-central/rev/4f07d49f1c7a823da07e3a231ac87c6435c8fd58/gfx/webrender_bindings/RenderTextureHostSWGL.cpp#104

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1675876 - Make RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL() fallible

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e2dfe331b79
Make RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL() fallible r=mattwoodrow

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6e2dfe331b79

Comment 8

[Pascal Chevrel:pascalc]

Should we uplift this fix to beta?

Comment 9

[Sotaro Ikeda [:sotaro]]

Yes, it seems necessary. Bug 1689186 enabled Software WebRender on beta.

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9199964 [details]
Bug 1675876 - Make RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL() fallible

Beta/Release Uplift Approval Request

• User impact if declined: GPU process crash happens when ShmemTextureHost failed to get valid Shmen with Software WebRender on Windows.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch removes MOZ_RELEASE_ASSERT() and WebRender already has a mechanism to handle an invalid RenderTextureHost rendering.
• String changes made/needed: None

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9199964 [details]
Bug 1675876 - Make RenderBufferTextureHostSWGL::RenderBufferTextureHostSWGL() fallible

Approved for 86 beta 6, thanks.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f479e734486