1676067 - Rename "Show blocked pop-up" to "Open blocked pop-up" in site info menu

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P5)

Description

[Poopooracoocoo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Actual results:

I thought that the button would show me the address of the pop-up. To see the address, you must click on the options button on the infobar for blocked pop-ups.

Expected results:

Instead it opened the pop-up.

Comment 1

[Poopooracoocoo]

Attachment: site info menu/pop-up

Comment 2

[Alin Ilea, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Hi,

I will move this enhancement over to a component so developers can take a look over it. If this is not the correct component please feel free to change it to an appropriate one.

Thanks for your report.

Comment 3

[Poopooracoocoo]

Well this is a very minor 'enhancement'.

Comment 4

[Paul Zühlcke [:pbz]]

Thanks for filing! I can see how this could be a bit confusing.
I don't think we want to actively look into it, but I'd accept a patch.

Comment 5

[Poopooracoocoo]

I don't think we want to actively look into it, but I'd accept a patch.

I imagine that this would be a one line change. A small change that has a significant benefit for security. I don't understand the Firefox codebase at all and it'd take me forever to make a patch.

Comment 6

[Poopooracoocoo]

An updates on this? Once again, this would be really beneficial for security. I would've expected it to show me the URL and not to open it.

Comment 7

[Ramya Praneetha :ramya]

Hi, I would like to work on this bug. Can it be assigned to me?

Comment 8

[Paul Zühlcke [:pbz]]

Sure! Thanks for working on this. Please let me know if you have questions.

Comment 9

[:prathiksha]

Ramya, one thing to note here is that we probably need the new string to be a fluent string[0]. So you'll have to remove the existing string from here[1] if it's not used anywhere else and then add the new string to browser.ftl or make a new file specific to site permissions called sitePermissions.ftl. I recommend creating a new sitePermissions.ftl file, browser.ftl tends to get crowded with a lot of generic stuff. Also, here's some fluent documentation I recommend checking out as you work with a count value passed from JS - https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html#plural-rules.

[0]https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html
[1]https://searchfox.org/mozilla-central/rev/be413c29deeb86be6cdac22445e0d0b035cb9e04/browser/locales/en-US/chrome/browser/browser.properties#272-275

Feel free to get in touch with me on Matrix if you're stuck :)

Comment 10

[Ramya Praneetha :ramya]

Attachment: Bug 1676067 - Renamed "Show blocked pop-up" to "Open blocked pop-up" in site info menu. r=prathiksha

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18eb9baedc2b
Renamed "Show blocked pop-up" to "Open blocked pop-up" in site info menu. r=prathiksha,fluent-reviewers,flod

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/18eb9baedc2b

Comment 13

[jayabalpersonals]

hello sir I want to download pdf files in https://www.tnpscrock.in/ but its shows the message popup is blocked how to resolve this please help me

Comment 14

[Paul Zühlcke [:pbz]]

(In reply to jayabalpersonals from comment #13)

hello sir I want to download pdf files in https://www.tnpscrock.in/ but its shows the message popup is blocked how to resolve this please help me

The issue you're describing isn't related to this bug. Please file a separate bug.