1676117 - Avoid a minor warning in test_webextensions_startup_remove.js

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

In debugging bug 1675506, I noticed that one of the errors mentioned in that bug was unnecessary, and one that I'd previously had been working around. Unfortunately in a later change I forgot to adapt the test for it.

Not sure if this is the cause or harmless:
:10.63 INFO "CONSOLE_MESSAGE: (error) [JavaScript Error: "can't access property "arm", this._batchTask is null" {file: "resource://gre/modules/SearchSettings.jsm" line: 145}]
task@resource://gre/modules/SearchSettings.jsm:145:11
_runTask@resource://gre/modules/DeferredTask.jsm:333:18
_timerCallback/<@resource://gre/modules/DeferredTask.jsm:305:20
_timerCallback@resource://gre/modules/DeferredTask.jsm:324:9
finalize@resource://gre/modules/DeferredTask.jsm:276:12
_ensurePendingWritesCompleted@resource://gre/modules/SearchSettings.jsm:180:18
get@resource://gre/modules/SearchSettings.jsm:97:16
_init@resource://gre/modules/SearchService.jsm:258:43
init@resource://gre/modules/SearchService.jsm:1273:18
test_removeAddonOnStartup@/home/magnus/Code/tb/mozilla/obj-x86_64-pc-linux-gnu/_tests/xpcshell/toolkit/components/search/tests/xpcshell/test_webextensions_startup_remove.js:67:25
_do_main@/home/magnus/Code/tb/mozilla/testing/xpcshell/head.js:239:6
_execute_test@/home/magnus/Code/tb/mozilla/testing/xpcshell/head.js:568:5
@-e:1:1

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1676117 - Avoid warning in test_webextensions_startup_remove.js by waiting for write after all initial setting changes are complete. r?daleharvey!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8803e66905e
Avoid warning in test_webextensions_startup_remove.js by waiting for write after all initial setting changes are complete. r=daleharvey

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d8803e66905e