Closed Bug 1676129 Opened 5 years ago Closed 5 years ago

In nsHttpConnection::EnsureNPNComplete, rv is overwritten wrongly

Categories

(Core :: Networking: HTTP, defect, P2)

Product:
Core
Component:
Networking: HTTP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1676129 - Don't overwrite the rv with the result from GetEsniUsed
47 bytes, text/x-phabricator-request
Details | Review

The rv here is assigned to the return value of GetEsniUsed, which is NS_OK. This makes this line never executed.

Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3638acf5ac17 Don't overwrite the rv with the result from GetEsniUsed r=necko-reviewers,valentin

https://hg.mozilla.org/mozilla-central/rev/3638acf5ac17

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: