1676140 - Updating alert's asignee resets the alerts filters

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Updating an alert's assignee from any framework/status resets the alert filters to talos/untriaged.
This is causing a tedious workflow for sheriffs that need to set the filters again after updating an alert status (except talos, offcourse).
The same thing happens when you're on a particular alert item instead of a particular filter.

Example: In raptor/untriaged try to assign un unassigned alert to yourself (press take or unassigned button and then press enter. The other way around (unassigning) happens the same thing.

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: click on "take" or "unassign" to unassign to yourself

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: page redirected from raptor/untriaged to talos/untriaged

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: click on asignee name to unassign (clear) the text box

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: page redirects from raptor/untraiged to talos/untriaged

Comment 5

[Sarah Clements [:sclements]]

This is so interesting.... it appears that hitting enter on that input element is acting like a submit event, causing a full page reload which is why the filters are reset. No idea why this would be happening with the routing change, but calling event.preventDefault in the onKeyPress function solves the problem.

I'll submit a patch for it but if you happen to see this happening somewhere else, this should solve the issue :)

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6857

Comment 7

[Sarah Clements [:sclements]]

The patch has been merged and deployed to production.

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Sarah Clements [:sclements] from comment #7)

The patch has been merged and deployed to production.

Thank you very much for your quick fix, Sarah!

Comment 9

[Sarah Clements [:sclements]]

You're welcome :)