1676332 - 9.49 - 56.57% glvideo Mean tick time across 100 ticks: / pdfpaint (windows10-64-shippable-qr) regression on push f408fc890ba11a49b9ea51c9554921212d3993d3 (Thu November 5 2020)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push f408fc890ba11a49b9ea51c9554921212d3993d3. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
57%	glvideo	Mean tick time across 100 ticks:	windows10-64-shippable-qr	e10s stylo webrender-sw	21.15 -> 33.11
57%	glvideo	Mean tick time across 100 ticks:	windows10-64-shippable-qr	e10s stylo webrender-sw	21.16 -> 33.12
9%	pdfpaint		windows10-64-shippable-qr	e10s stylo webrender-sw	361.04 -> 395.28

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
42%	glterrain		windows10-64-shippable-qr	e10s stylo webrender-sw	8.35 -> 4.81

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1673983

Comment 2

[Matt Woodrow (:mattwoodrow)]

Glvideo is expected, since we're now allowing the hardware video decoders to be enabled (if not otherwise blocklisted). This will improve video playback performance significantly, but means we have to do a readback into software when using OOP WebGL.

Fixing the readback is already planned work from the WebGL team, but I think this is a good tradeoff in the meantime.

I'll look into pdfpaint, that's less expected.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1676332 - Use D3D11 staging textures within RenderCompositorD3D11SWGL for faster uploads. r?lsalzman

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e767b7053baa
Use D3D11 staging textures within RenderCompositorD3D11SWGL for faster uploads. r=lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing reftest failures.

Backout link : https://hg.mozilla.org/integration/autoland/rev/68867f327c6267f971e6483443148a4025f94633

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=M99YRg_ySv6MNZpHofMLTw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=e767b7053baab1cf4e4a93e01c2d17fb098e5c08

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321421482&repo=autoland&lineNumber=1752

" REFTEST INFO | Application command: C:\Users\task_1605080093\build\application\firefox\firefox.exe -marionette --wait-for-browser -profile c:\users\task_1605080093\appdata\local\temp\tmpi2cyzq.mozrunner
[task 2020-11-11T07:41:44.135Z] 07:41:44 INFO - ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1605080093\appdata\local\temp\tmpi2cyzq.mozrunner\runreftest_leaks.log
[task 2020-11-11T07:41:44.135Z] 07:41:44 INFO - [3552, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:251
[task 2020-11-11T07:41:44.738Z] 07:41:44 INFO - [WARN rkv::backend::impl_safe::environment] load_ratio() is irrelevant for this storage backend.
[task 2020-11-11T07:41:44.938Z] 07:41:44 INFO - [3552, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/layout/style/Loader.cpp:1992
[task 2020-11-11T07:41:44.977Z] 07:41:44 INFO - ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1605080093\appdata\local\temp\tmpi2cyzq.mozrunner\runreftest_leaks_gpu_pid4876.log
[task 2020-11-11T07:41:44.977Z] 07:41:44 INFO - [4876, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:251
[task 2020-11-11T07:41:45.016Z] 07:41:45 INFO - 1605080505015 Marionette TRACE Marionette enabled
[task 2020-11-11T07:41:45.121Z] 07:41:45 INFO - 1605080505116 Marionette TRACE Received observer notification toplevel-window-ready
[task 2020-11-11T07:41:45.160Z] 07:41:45 INFO - [3552, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4282
[task 2020-11-11T07:41:45.165Z] 07:41:45 INFO - [3552, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4282
[task 2020-11-11T07:41:45.305Z] 07:41:45 INFO - [3552, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1132
[task 2020-11-11T07:41:45.586Z] 07:41:45 INFO - Warning: asking to enable_gpu_markers but no supporting extension was found
[task 2020-11-11T07:41:45.651Z] 07:41:45 INFO - [Parent 3552, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1552
[task 2020-11-11T07:41:45.690Z] 07:41:45 INFO - ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1605080093\appdata\local\temp\tmpi2cyzq.mozrunner\runreftest_leaks_tab_pid4928.log
[task 2020-11-11T07:41:45.690Z] 07:41:45 INFO - [4928, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:251
[task 2020-11-11T07:41:45.729Z] 07:41:45 INFO - Assertion failure: (((HRESULT)(hr)) >= 0), at /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderCompositorD3D11SWGL.cpp:318
[task 2020-11-11T07:41:45.769Z] 07:41:45 INFO - [Parent 3552, Main Thread] WARNING: NS_ENSURE_TRUE(presShell) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4280
[task 2020-11-11T07:41:45.828Z] 07:41:45 INFO - [Child 4928, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/layout/style/Loader.cpp:1992
[task 2020-11-11T07:41:45.838Z] 07:41:45 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2020-11-11T07:41:55.626Z] 07:41:55 INFO - #01: webrender::renderer::Renderer::update_native_surfaces() [gfx/wr/webrender/src/renderer.rs:6226]"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87c7e2e04dc2
Use D3D11 staging textures within RenderCompositorD3D11SWGL for faster uploads. r=lsalzman

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/87c7e2e04dc2